From 414ef1260e50b5a92a29d104e7a84dd9f1695865 Mon Sep 17 00:00:00 2001 From: Auguste Baum Date: Mon, 3 Mar 2025 16:00:37 +0100 Subject: [PATCH] replace kwargs by actual arguments --- .../_estimator/feature_importance_accessor.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/skore/src/skore/sklearn/_estimator/feature_importance_accessor.py b/skore/src/skore/sklearn/_estimator/feature_importance_accessor.py index 79756ab4d..ee5e0711a 100644 --- a/skore/src/skore/sklearn/_estimator/feature_importance_accessor.py +++ b/skore/src/skore/sklearn/_estimator/feature_importance_accessor.py @@ -4,6 +4,7 @@ import joblib import numpy as np import pandas as pd +from numpy.random import RandomState from numpy.typing import ArrayLike from sklearn.base import is_classifier from sklearn.inspection import permutation_importance @@ -112,7 +113,11 @@ def feature_permutation( X: Optional[ArrayLike] = None, y: Optional[ArrayLike] = None, scoring: Optional[Scoring] = None, - **kwargs, + n_repeats: int = 5, + n_jobs: Optional[int] = None, + random_state: Optional[Union[int, RandomState]] = None, + sample_weight: Optional[ArrayLike] = None, # Sample weights used in scoring. + max_samples: float = 1.0, ) -> pd.DataFrame: """Report the permutation feature importance. @@ -184,7 +189,11 @@ def feature_permutation( X=X, y=y, scoring=scoring, - **kwargs, + n_repeats=n_repeats, + n_jobs=n_jobs, + random_state=random_state, + sample_weight=sample_weight, + max_samples=max_samples, ) def _feature_permutation(