Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multi-variable environment in spn.Product #76

Open
fsaad opened this issue Apr 29, 2020 · 1 comment
Open

Implement multi-variable environment in spn.Product #76

fsaad opened this issue Apr 29, 2020 · 1 comment

Comments

@fsaad
Copy link
Collaborator

fsaad commented Apr 29, 2020

https://github.com/probcomp/sum-product-dsl/blob/c482341d04ef35febefc46f8821350e9236e8013/src/spn.py#L409-L413

  1. The multivariable transform must be of type event.
  2. If a condition or logprob query has multivariate symbol, then we cannot call logprob_factored on the children. Instead, we need to reassemble the query post-substitution and call self.logprob on the new query, which will take care of converting it to dnf, solving it, and factoring it again.
@fsaad
Copy link
Collaborator Author

fsaad commented Oct 27, 2020

Related #92, since min/max can be of the form min(X1, X2, ..., Xn).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fsaad