Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend example test generation to non-image tests #123

Open
jeremydouglass opened this issue Jun 15, 2017 · 3 comments
Open

Extend example test generation to non-image tests #123

jeremydouglass opened this issue Jun 15, 2017 · 3 comments

Comments

@jeremydouglass
Copy link
Member

Currently hack/generate-e2e-test.py generates tests for sketches with a reference image defined in .test.yml.

This could be extended to also generate tests for sketches that have other criteria -- for example, specifying a hook (to be appended to the sketch) and an expected result:

test:
    result: True
    hook: "result <- focused"
@gaocegege
Copy link
Member

I am not sure if it works, since we use xvfb in travis CI to do the test. I am not familiar with the logic in it about focus.

@jeremydouglass
Copy link
Member Author

Yes, focused may be a bad example.

Are there other things in the API without visual output that would be worth testing in the mode -- such as loadTable, for example?

@gaocegege
Copy link
Member

Yeah, there are some functions should be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants