-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build instructions #255
Comments
I will file a PR to add build instructions into README. |
I think we have docs about building here: https://github.com/processing-r/Processing.R/blob/master/raw-docs/devel/compilation.md Do you need the docs about how to release a mode into docs/? |
Great, thank you -- I will read https://github.com/processing-r/Processing.R/blob/master/raw-docs/devel/compilation.md and see if i can create a build. A new build for 1.0.7 should only change urls in the documentation and the build number, but hopefully it will get Contributions Manager installs working again in #254, as it can now list and download the zip, but fails to install. |
Yes, that would be very helpful!-- mode release instructions. When I was last building I was building straight into my local PDE for testing, but now this is for distribution. |
@gaocegege -- I have continuous integration on travis and appveyor working. To build a new release locally, this is what I figured out:
However I am not sure about rebuilding the documentation files and updating https://processing-r.github.io/. Could you help with doc build instructions please? |
Yeah, of course. I am trying to build the docs from scratch. I was using macOS when I built the docs website. Now I am using Linux. I cannot build Processing now since I did not install the JDK 6. We need to build Processing and Processing.R runner.jar first, then we can use the runner.jar to build the docs website. |
Thanks so much for looking at it.
Got it. I've now also run into a build problem on Mac for the mode. I have jdk 10, and it needs jdk 8 (not 6) -- which I have installed, but somehow setting
I've also noticed that the mode.properties created by deploy doesn't seem formatted in the expected way to match the previous distribution -- that one might have been hand-edited. Tried manually editing it, but I'll look over the template / generator script later. |
On MacOS I was able to upload a valid version of releases/v1.0.7 that installs in Contributions Manager without errors (build not including updated docs).
/Library/Java/JavaVirtualMachines/jdk1.8.0_192.jdk/
Add a line to the Processing.R scripts/deploy.sh defining JAVA_HOME. I used the mac java_home command, but this can just be a path.
This gives the Contents/Home of the Java 8 jdk I tried exporting JAVA_HOME from the shell and then running deploy.sh, but it did not work.
I'm running deploy.sh from its own directory -- BASH_SOURCE isn't defined / isn't loading through source like it should, so source is giving a file-not-found error for generator-util.sh. Change line to:
The log may show a warning that will also indicate it is correctly using 1.8 (jdk8):
Also, re: "I've also noticed that the mode.properties created by deploy doesn't seem formatted in the expected way to match the previous distribution" -- I was wrong. dist/mode.properties does look different, but the version that ends up in the zip is correct. |
Need to clean up the docs configuration as well. Currently, docs are on GitHub pages here: https://processing-r.github.io/ ...and they link to https://github.com/gaocegege/Processing.R, which is outdated and autoforward to https://github.com/processing-r/Processing.R. That repo (this one, the main one) has GitHub pages activated -- it builds out of master:/docs to https://processing-r.github.io/Processing.R/ ...but master:/docs doesn't contain the docs, just the release, and so the link 404.
Instead, the website is published out of the default org GitHub Pages repo: https://github.com/processing-r/processing-r.github.io ...and it should be updated and committed by running the doc-tools repo: https://github.com/processing-r/Processing.R-docs-tools ...on the contents of the main mode repo. We just need to reconstruct how to do that -- the scripts in doc-tools are unclear. |
As far as I can tell, on the doc-tools site, the entry point is: scripts/generate-reference.sh and the undocumented command line arguments that should be passed through to src/generate.py are
So we need to provide the runner.jar location. However, the dist doesn't build a runner.jar. I found a reference in the Dockerfile:
and then in generate-ant-file-in-docker.sh:
...but I don't see anything there that would specifically create a runner.jar. I'm just guessing here, but is it possible that runner.jar could only be created through docker, and the when docker was deprecated the docker-specific build info for runner was removed from build.xml? The way that I see to recover the build environment is to go to an old docker container: https://quay.io/repository/gaocegege/processing.r?tab=history |
@gaocegege -- wait. is "runner.jar" actually RLangMode.jar? That is what it looks like in the dockerfile. If that is the case, that would make things easier.... Lines 51 to 55 in e13afbe
|
We can run |
@gaocegege -- what are the current build instructions?
CONTRIBUTING.md says "Read the README.md for build instructions" -- but it doesn't have build instructions. I'm looking through various artifacts -- docker, travis, appveyor, a build.xml for ant (eclipse?), and a set of scripts, e.g. deploy -- and trying to reconstruct a build setup for when I roll up a new release.
The text was updated successfully, but these errors were encountered: