-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor crashes if there's a shader error #2298
Comments
Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already. |
I'm getting lots of page crashes too. Minimal example, no shaders: https://editor.p5js.org/jwong/sketches/SaB4RgMl4 And this seems to have started happening since yesterday's editor release. The error message from Firefox:
Screenshot of error from a Chrome-based browser: And just noticed #2296 , same issue |
Here's some more logs from the error:
In my testing, changing Editor.jsx line 270 from checking This might be caused by changes to the friendly error system that were pushed as part of the latest release over at the Using |
@wong-justin Yeah I think that's going to be the best solution. You can put in a PR with the downgrade, if you want to. Pinging @raclim -- this seems pretty serious. Can we put out a new release quickly? Something changed in
This is the
and this is the
This is the change on their end which is causing problems for us: Sometimes we do have that I'm not sure at this point why we do have it on the p5 friendly error and not on the runtime error. So that's something I can look into. I can also put in a PR to |
Discussed in processing#2298 Hopefully a temporary fix until workarounds / updates are made
Thanks so much @JasonGoemaat @wong-justin @lindapaiste for working together to resolve this! I'm really sorry that this happened due to my major oversight in upgrading the I just pushed out a new release with the changes, and tweaked @wong-justin's PR afterwards to include the updates to the lockfile as well. It seems to be working for me for now, but please let me know if this persists. Sorry again about this! |
p5.js version
v1.7.0
What is your operating system?
Windows
Web browser and version
Chrome -114.0.5735.199
Actual Behavior
An error in javascript or a shader causes a crash to an empty white page with this in the console:
Uncaught TypeError: Failed to execute 'useProgram' on 'WebGL2RenderingContext': parameter 1 is not of type 'WebGLProgram'
Expected Behavior
An error in the console which is visible on the page.
Steps to reproduce
Steps:
1
instead of1.0
in a shader:throw new Error("Test");
The text was updated successfully, but these errors were encountered: