Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning of codebase by removing unused components in client folder . #2555

Closed
yashpandey06 opened this issue Nov 1, 2023 · 2 comments · Fixed by #2561
Closed

Cleaning of codebase by removing unused components in client folder . #2555

yashpandey06 opened this issue Nov 1, 2023 · 2 comments · Fixed by #2561
Labels
Area: Code Quality Enhancement

Comments

@yashpandey06
Copy link
Contributor

yashpandey06 commented Nov 1, 2023 •
edited
Loading

Increasing Access

Proposing this idea would help the new contributors better understand the code as the official React Documentation promotes hooks and functional components.

Feature enhancement details

Update the code in this file to use functional components, aligning it with the latest React version. This change will make it more accessible for new contributors to understand, modify, and improve the codebase.

can I work on this @lindapaiste and @raclim
@lindapaiste
Copy link
Collaborator

Hey, I think the NavBasic was not mentioned in #2358 because it is not actually used anywhere? If so, we should delete it rather than converting it.

@yashpandey06
Copy link
Contributor Author

Okay @lindapaiste I understand your point .
So it will be a good thing to remove unnecessary codes which aren't in use to make codebase look more organised and useful .

@yashpandey06 yashpandey06 changed the title Converting NavBasic class component to functional React component Cleaning of codebase by removing unused components in client folder . Nov 2, 2023
This was referenced Nov 2, 2023
Closed
Merged
@yashpandey06 yashpandey06 mentioned this issue Nov 2, 2023
Merged
@lindapaiste lindapaiste mentioned this issue Dec 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Code Quality Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleaned the codebase by removing unused files inside client/component…
2 participants
@lindapaiste @yashpandey06