Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change log verbosity without restarting the controller #154

Open
masayag opened this issue Mar 27, 2022 · 0 comments
Open

Allow to change log verbosity without restarting the controller #154

masayag opened this issue Mar 27, 2022 · 0 comments

Comments

@masayag
Copy link
Collaborator

masayag commented Mar 27, 2022

The current implementation of flotta's logging is done by watching a configmap.
When the log_level element of that map is changed, the pod is being restarted.
While this allows to apply new log verbosity level in all operators, there are less desired side-effects, such as
initializing the entire-cache (depends on the scale, can take sometime + introduce unnecessary load on etcd/api-server).

Using https://pkg.go.dev/go.uber.org/zap#AtomicLevel, the log verbosity could be changed on the fly.
We'd like to explore that approach and to minimize the restarted when can be avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants