Shirakami-CI

no-NOLINT (src/, include/) for CI #3872

Sign in to view logs

Triggered via push January 16, 2025 07:29

no-nolint

Status Failure

Total duration 2m 56s

Artifacts –

ci-build.yml

on: push

Matrix: Build

Annotations

1 error and 50 warnings

- *<https://github.com/project-tsurugi/shirakami/runs/35697971618?check_suite_focus=true|[Clang-Tidy] 314 warnings>*

hicpp-signed-bitwise: src/concurrency_control/include/wp_lock.h#L10

use of a signed integer operand with a binary bitwise operator

readability-implicit-bool-conversion: src/concurrency_control/include/wp_lock.h#L10

implicit conversion 'unsigned long' -> bool

hicpp-signed-bitwise: src/concurrency_control/wp_lock.cpp#L19

use of a signed integer operand with a binary bitwise operator

hicpp-signed-bitwise: src/concurrency_control/wp_lock.cpp#L30

use of a signed integer operand with a binary bitwise operator

hicpp-signed-bitwise: src/concurrency_control/wp_lock.cpp#L32

use of a signed integer operand with a binary bitwise operator

cppcoreguidelines-pro-bounds-pointer-arithmetic: include/shirakami/binary_printer.h#L39

do not use pointer arithmetic

cppcoreguidelines-pro-bounds-pointer-arithmetic: include/shirakami/binary_printer.h#L48

do not use pointer arithmetic

cppcoreguidelines-pro-type-union-access: src/include/memory.h#L22

do not access members of unions; use (boost::)variant instead

cppcoreguidelines-pro-type-vararg,hicpp-vararg: src/include/memory.h#L32

do not call c-style vararg functions

google-explicit-constructor,hicpp-explicit-conversions: include/shirakami/storage_options.h#L32

single-argument constructors must be marked explicit to avoid unintentional implicit conversions

bugprone-implicit-widening-of-multiplication-result: src/concurrency_control/include/epoch.h#L34

performing an implicit widening conversion to type 'std::atomic<unsigned long>::__integral_type' (aka 'unsigned long') of a multiplication performed in type 'int'

cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers: src/concurrency_control/include/epoch.h#L34

40 is a magic number; consider replacing it with a named constant

cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers: src/concurrency_control/include/epoch.h#L34

1000 is a magic number; consider replacing it with a named constant

fuchsia-statically-constructed-objects: src/concurrency_control/include/epoch.h#L50

static objects are disallowed; if possible, use a constexpr constructor instead

fuchsia-statically-constructed-objects: src/concurrency_control/include/epoch.h#L52

static objects are disallowed; if possible, use a constexpr constructor instead

fuchsia-statically-constructed-objects: src/database/include/tx_state_notification.h#L10

static objects are disallowed; if possible, use a constexpr constructor instead

performance-unnecessary-value-param: src/database/tx_state_notification.cpp#L39

the const qualified parameter 'cb' is copied for each invocation; consider making it a reference

fuchsia-default-arguments-declarations: src/include/storage.h#L157

declaring a parameter with a default argument is disallowed

fuchsia-statically-constructed-objects: src/include/storage.h#L219

static objects are disallowed; if possible, use a constexpr constructor instead

cppcoreguidelines-special-member-functions,hicpp-special-member-functions: src/concurrency_control/include/tid.h#L18

class 'tid_word' defines a copy constructor and a copy assignment operator but does not define a destructor, a move constructor or a move assignment operator

misc-non-private-member-variables-in-classes: src/concurrency_control/include/tid.h#L20

member variable '' has public visibility

cppcoreguidelines-pro-type-member-init,hicpp-member-init: src/concurrency_control/include/tid.h#L35

constructor does not initialize these fields: lock_, lock_by_gc_, latest_, absent_, tid_, by_short_, epoch_

cppcoreguidelines-pro-type-member-init,hicpp-member-init: src/concurrency_control/include/tid.h#L39

constructor does not initialize these fields: lock_, lock_by_gc_, latest_, absent_, tid_, by_short_, epoch_

google-explicit-constructor,hicpp-explicit-conversions: src/concurrency_control/include/tid.h#L39

single-argument constructors must be marked explicit to avoid unintentional implicit conversions

cppcoreguidelines-pro-type-member-init,hicpp-member-init: src/concurrency_control/include/tid.h#L40

constructor does not initialize these fields: lock_, lock_by_gc_, latest_, absent_, tid_, by_short_, epoch_

cert-oop54-cpp: src/concurrency_control/include/tid.h#L43

operator=() does not handle self-assignment properly

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L44

do not access members of unions; use (boost::)variant instead

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L49

do not access members of unions; use (boost::)variant instead

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L57

do not access members of unions; use (boost::)variant instead

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L61

do not access members of unions; use (boost::)variant instead

readability-make-member-function-const: src/concurrency_control/include/tid.h#L64

method 'empty' can be made const

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L64

do not access members of unions; use (boost::)variant instead

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L66

do not access members of unions; use (boost::)variant instead

modernize-use-nodiscard: src/concurrency_control/include/tid.h#L68

function 'get_obj' should be marked [[nodiscard]]

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L68

do not access members of unions; use (boost::)variant instead

readability-make-member-function-const: src/concurrency_control/include/tid.h#L70

method 'get_lock' can be made const

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L70

do not access members of unions; use (boost::)variant instead

readability-make-member-function-const: src/concurrency_control/include/tid.h#L72

method 'get_lock_by_gc' can be made const

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L72

do not access members of unions; use (boost::)variant instead

modernize-use-nodiscard: src/concurrency_control/include/tid.h#L74

function 'get_lock' should be marked [[nodiscard]]

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L74

do not access members of unions; use (boost::)variant instead

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L77

do not access members of unions; use (boost::)variant instead

readability-make-member-function-const: src/concurrency_control/include/tid.h#L80

method 'get_latest' can be made const

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L80

do not access members of unions; use (boost::)variant instead

modernize-use-nodiscard: src/concurrency_control/include/tid.h#L82

function 'get_latest' should be marked [[nodiscard]]

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L82

do not access members of unions; use (boost::)variant instead

readability-make-member-function-const: src/concurrency_control/include/tid.h#L84

method 'get_absent' can be made const

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L84

do not access members of unions; use (boost::)variant instead

modernize-use-nodiscard: src/concurrency_control/include/tid.h#L86

function 'get_absent' should be marked [[nodiscard]]

cppcoreguidelines-pro-type-union-access: src/concurrency_control/include/tid.h#L86

do not access members of unions; use (boost::)variant instead