Skip to content

NOLINT

NOLINT #3874

Triggered via push January 16, 2025 08:35
Status Failure
Total duration 2m 37s
Artifacts

ci-build.yml

on: push
Matrix: Build
Fit to window
Zoom out
Zoom in

Annotations

1 error and 50 warnings
cppcoreguidelines-owning-memory: src/concurrency_control/record.cpp#L18
deleting a pointer through a type that is not marked 'gsl::owner<>'; consider using a smart pointer instead
cppcoreguidelines-owning-memory: src/concurrency_control/record.cpp#L24
initializing non-owner argument of type 'std::atomic<shirakami::version *>::__pointer_type' (aka 'shirakami::version *') with a newly created 'gsl::owner<>'
cppcoreguidelines-owning-memory: src/concurrency_control/record.cpp#L32
initializing non-owner argument of type 'std::atomic<shirakami::version *>::__pointer_type' (aka 'shirakami::version *') with a newly created 'gsl::owner<>'
bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions: src/include/cpu.h#L39
narrowing conversion from 'long' to signed type 'int' is implementation-defined
bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions: src/include/cpu.h#L47
narrowing conversion from 'long' to signed type 'pid_t' (aka 'int') is implementation-defined
cppcoreguidelines-pro-type-vararg,hicpp-vararg: src/include/cpu.h#L47
do not call c-style vararg functions
bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions: src/include/cpu.h#L60
narrowing conversion from 'long' to signed type 'pid_t' (aka 'int') is implementation-defined
cppcoreguidelines-pro-type-vararg,hicpp-vararg: src/include/cpu.h#L60
do not call c-style vararg functions
bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions: src/include/cpu.h#L69
narrowing conversion from 'long' to signed type 'pid_t' (aka 'int') is implementation-defined
cppcoreguidelines-pro-type-vararg,hicpp-vararg: src/include/cpu.h#L69
do not call c-style vararg functions
fuchsia-default-arguments-declarations: src/concurrency_control/include/wp_meta.h#L127
declaring a parameter with a default argument is disallowed
hicpp-no-assembler: src/include/tsc.h#L15
do not use inline assembler in safety-critical code
hicpp-no-assembler: src/include/tsc.h#L16
do not use inline assembler in safety-critical code
hicpp-signed-bitwise: src/include/tsc.h#L18
use of a signed integer operand with a binary bitwise operator
cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers: src/include/tsc.h#L18
32 is a magic number; consider replacing it with a named constant
hicpp-no-assembler: src/include/tsc.h#L26
do not use inline assembler in safety-critical code
hicpp-signed-bitwise: src/include/tsc.h#L28
use of a signed integer operand with a binary bitwise operator
cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers: src/include/tsc.h#L28
32 is a magic number; consider replacing it with a named constant
fuchsia-default-arguments-declarations: include/shirakami/api_storage.h#L28
declaring a parameter with a default argument is disallowed
google-explicit-constructor,hicpp-explicit-conversions: include/shirakami/database_options.h#L19
single-argument constructors must be marked explicit to avoid unintentional implicit conversions
cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers: include/shirakami/database_options.h#L102
40000 is a magic number; consider replacing it with a named constant
fuchsia-default-arguments-declarations: include/shirakami/interface.h#L162
declaring a parameter with a default argument is disallowed
fuchsia-default-arguments-declarations: include/shirakami/interface.h#L177
declaring a parameter with a default argument is disallowed
fuchsia-default-arguments-declarations: include/shirakami/interface.h#L261
declaring a parameter with a default argument is disallowed
fuchsia-default-arguments-declarations: include/shirakami/interface.h#L262
declaring a parameter with a default argument is disallowed
fuchsia-default-arguments-declarations: include/shirakami/interface.h#L388
declaring a parameter with a default argument is disallowed
misc-non-private-member-variables-in-classes: include/shirakami/log_record.h#L96
member variable 'operation_' has public visibility
misc-non-private-member-variables-in-classes: include/shirakami/log_record.h#L101
member variable 'key_' has public visibility
misc-non-private-member-variables-in-classes: include/shirakami/log_record.h#L107
member variable 'value_' has public visibility
misc-non-private-member-variables-in-classes: include/shirakami/log_record.h#L113
member variable 'major_version_' has public visibility
misc-non-private-member-variables-in-classes: include/shirakami/log_record.h#L119
member variable 'minor_version_' has public visibility
misc-non-private-member-variables-in-classes: include/shirakami/log_record.h#L124
member variable 'storage_id_' has public visibility
google-explicit-constructor,hicpp-explicit-conversions: include/shirakami/transaction_options.h#L75
single-argument constructors must be marked explicit to avoid unintentional implicit conversions
performance-unnecessary-value-param: include/shirakami/transaction_options.h#L215
the const qualified parameter 'to' is copied for each invocation; consider making it a reference
fuchsia-statically-constructed-objects: include/shirakami/transaction_state.h#L227
static objects are disallowed; if possible, use a constexpr constructor instead
fuchsia-statically-constructed-objects: include/shirakami/transaction_state.h#L229
static objects are disallowed; if possible, use a constexpr constructor instead
fuchsia-statically-constructed-objects: src/database/include/database.h#L9
static objects are disallowed; if possible, use a constexpr constructor instead
cert-err58-cpp: src/database/include/database.h#L9
initialization of 'used_database_options_' with static storage duration may throw an exception that cannot be caught
fuchsia-default-arguments-declarations: src/database/include/thread_pool.h#L23
declaring a parameter with a default argument is disallowed
cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers: src/database/include/thread_pool.h#L23
10 is a magic number; consider replacing it with a named constant
modernize-make-unique: src/database/include/thread_pool.h#L28
use std::make_unique instead
cppcoreguidelines-owning-memory: src/database/include/thread_pool.h#L28
initializing non-owner argument of type 'std::thread *' with a newly created 'gsl::owner<>'
fuchsia-statically-constructed-objects: src/database/include/thread_pool.h#L97
static objects are disallowed; if possible, use a constexpr constructor instead
fuchsia-statically-constructed-objects: src/database/include/thread_pool.h#L102
static objects are disallowed; if possible, use a constexpr constructor instead
cert-err58-cpp: src/database/include/thread_pool.h#L102
initialization of 'task_queue_' with static storage duration may throw an exception that cannot be caught
readability-const-return-type: src/include/atomic_wrapper.h#L27
return type 'const bool' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
readability-const-return-type: src/include/atomic_wrapper.h#L27
return type 'const char' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
fuchsia-statically-constructed-objects: src/datastore/limestone/include/datastore.h#L10
static objects are disallowed; if possible, use a constexpr constructor instead