build: fix RPATH settings to work even if libdir is not "lib" #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tsurugi が主にサポートしている Ubuntu では、インストールディレクトリの下に
libディレクトリを作成し、そこに共有ライブラリファイルを配置しますが、RHEL 派生 Linux ディストリビューション等では、これが
lib64ディレクトリとなるため、 INSTALL_RPATH で指定している場所と異なり起動時に問題となることがあります。関連案件: project-tsurugi/tsurugi-issues#1066
この問題に対処する修正です。
以上に加えて、 add_executable される mock_server に対して
INSTALL_RPATH "\$ORIGIN"が指定されていましたが、これはbin下にインストールされ、そこから libdir を見に行く必要があるはずですので、 libdir を指すように修正を加えました。