Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include stats information with stream mode #469

Open
ghost opened this issue Jan 2, 2022 · 1 comment
Open

Include stats information with stream mode #469

ghost opened this issue Jan 2, 2022 · 1 comment
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Type: Enhancement Most issues will probably ask for additions or changes. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.

Comments

@ghost
Copy link

ghost commented Jan 2, 2022 •
edited by ghost
Loading

httpx version:

1.1.4

Current Behavior:

When using httpx together with -stream and -stats, stats don't actually show up.

Expected Behavior:

Statistics show up even when using -stream and hitting a key.

Steps To Reproduce:

Run httpx -l domains.txt -stream -stats and press any key to see that the statistics indicator doesn't work.
@ghost ghost added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 2, 2022
@ehsandeep ehsandeep added Type: Enhancement Most issues will probably ask for additions or changes. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix and removed Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Jan 10, 2022
@ehsandeep
Copy link
Member

@Yardanico thanks for reporting this, this is not a bug, as stats are calculated over total data, and -stream is supposed to be used for stdin or run time input, so in that case, the current stats information can not be applied, but we will see what information or change we can make to print some meaningful information if stats and stream flag used together.

@ehsandeep ehsandeep changed the title -stats doesn't work with -stream Include stats information with stream mode Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Type: Enhancement Most issues will probably ask for additions or changes. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ehsandeep