From c5a39494734b1121f03e4d0536b276c801890961 Mon Sep 17 00:00:00 2001
From: shubo <814183583@qq.com>
Date: Tue, 23 Jul 2024 09:25:46 +0800
Subject: [PATCH] fix: Missing close statements file.Close() & ticker.Stop()

---
 internal/pdcp/writer.go        | 2 +-
 pkg/scan/charts/echarts.go     | 1 +
 pkg/scan/events/stats_build.go | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/internal/pdcp/writer.go b/internal/pdcp/writer.go
index 5dfda78ca2..2197041137 100644
--- a/internal/pdcp/writer.go
+++ b/internal/pdcp/writer.go
@@ -142,7 +142,7 @@ func (u *UploadWriter) autoCommit(ctx context.Context, r *io.PipeReader) {
 	// temporary buffer to store the results
 	buff := &bytes.Buffer{}
 	ticker := time.NewTicker(flushTimer)
-
+	defer ticker.Stop()
 	for {
 		select {
 		case <-ctx.Done():
diff --git a/pkg/scan/charts/echarts.go b/pkg/scan/charts/echarts.go
index a2a9815888..69960588da 100644
--- a/pkg/scan/charts/echarts.go
+++ b/pkg/scan/charts/echarts.go
@@ -30,6 +30,7 @@ func (s *ScanEventsCharts) GenerateHTML(filePath string) error {
 	if err != nil {
 		return err
 	}
+	defer output.Close()
 	return page.Render(output)
 }
 
diff --git a/pkg/scan/events/stats_build.go b/pkg/scan/events/stats_build.go
index 0f01724411..6fe5f27174 100644
--- a/pkg/scan/events/stats_build.go
+++ b/pkg/scan/events/stats_build.go
@@ -56,6 +56,7 @@ func (s *ScanStatsWorker) initEventsFile() error {
 	if err != nil {
 		return err
 	}
+	defer f.Close()
 	s.enc = json.NewEncoder(f)
 	return nil
 }