-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] JDK 23 compatibility #3722
Comments
I can reproduce this error in some other context (also involving calling compilation task programatically): https://ci.eclipse.org/ls/job/jdt-ls-javac/lastCompletedBuild/testReport/org.eclipse.jdt.ls.core.internal.handlers/RenameHandlerTest/testLombokSingular/ lombok/src/utils/lombok/javac/Javac.java Line 364 in 1ac3950
|
GraalVM compatibility:
|
OpenJDK 23 also throws the above error. The ASM shadow can't handle version 23 bytecode. |
Aside from the Javadoc error, lombok-patcher needs to be released first: projectlombok/lombok.patcher#15 and then lombok should be updated to use the new patcher. |
It looks like SneakyThrowsRemover also needs some fiddling:
|
This should be fixed by my PR, can you try the artifact build by our pipeline? |
@Rawi01 works quite well, thank you. |
@mmoayyed how exactly does one reproduce this? I just migrated an existing project from Java 22 to 23 and it was built successfully. Stack:
I would like to know exactly which conditions trigger the incompatibility with lombok. |
With Liquibase 4.29.2, and with
DataChangeExecListener
|
Is this |
I've been running edge release for a while. Can we get a release going please? |
It seems that the use of Lombok's |
The title hints that all issues regarding Java 23 would be included. Please change it otherwise, thanks. |
is there any estimated time when lombok will support Java23?
|
Yes, the title does, but the content of the first post doesn't, focusing on a single issue. I don't have any editing or mod priviledge here. I think that each issue should be submitted in a different bug report, this one either has a title too broad or should be written as an umbrella-issue right from the start. Further, the title contains "[FEATURE]" when it is in fact a "[BUG]" report. This is important, since bugfixes normally have higher priority (not that it really makes a difference in this project though). |
I think all the bugs already have separate issues. This issue (IMHO) is mostly about the release of the artifact |
|
Describe the feature
Allow lombok to support building against JDK 23.
Describe the target audience
While JDK 23 is still in RC mode as of this writing, there are RC builds available nonetheless that one can use for experimentation and preparation against the next JDK release.
Additional context
Lombok today, 1.8.34, seems unable to build against JDK 23. To start with, there is the following error:
Originally reported here: google/error-prone#4532
Judging by the trace, this line seems to suggest that this is more of a Lombok issue, rather than Gradle or Error Prone:
JDK:
Gradle:
Related: projectlombok/lombok.patcher#15
The text was updated successfully, but these errors were encountered: