Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve node_reboot_required metric #230

Open
debian777 opened this issue Dec 5, 2024 · 1 comment
Open

Improve node_reboot_required metric #230

debian777 opened this issue Dec 5, 2024 · 1 comment

Comments

@debian777
Copy link

https://github.com/prometheus-community/node-exporter-textfile-collector-scripts/blob/a2b43e19be1e64c31b626ca827506977cac93488/apt_info.py#L112C31-L112C51

in Ubuntu,, script https://git.launchpad.net/ubuntu/+source/update-notifier/tree/data/update-motd-reboot-required#n6 not only tests if file exist but also examines content of this file.

The difference is that with live kernel patching, file exist but remains empty. This does not trigger *** System restart required *** message.

@dswarbrick
Copy link
Member

So, checking for a non-zero file size (if the file exists) would be a suitable test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants