Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting constant native histograms #1617

Open
dashpole opened this issue Sep 4, 2024 · 3 comments · Fixed by #1654
Open

Consider supporting constant native histograms #1617

dashpole opened this issue Sep 4, 2024 · 3 comments · Fixed by #1654

Comments

@dashpole
Copy link

dashpole commented Sep 4, 2024

For OpenTelemetry's prometheus exporters, we would like to be able to export OTel exponential histograms: open-telemetry/opentelemetry-collector-contrib#33703, open-telemetry/opentelemetry-go#5777.

It would be helpful to have a NewConstNativeHistogram constructor, which mirrors the NewConstHistogram constructor. Unclear if we need all of the variants (Vec, with CT, etc).

Alternatively, we could directly implement the prometheus.Metric interface. I don't think it would be that hard to do, but I haven't tried. Feel free to close this issue if we should go that route instead.

@ArthurSens
Copy link
Member

I'm supportive :)

@Maniktherana
Copy link

I can give this a shot if thats okay

@beorn7
Copy link
Member

beorn7 commented Nov 14, 2024

As we still need to support exemplars on the const native histogram, I re-open this.

See #1654 (comment) for details how to implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants