Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gateway configurations JSON serializable and save it with payments and subscriptions #196

Open
remcotolsma opened this issue Aug 27, 2021 · 1 comment

Comments

@remcotolsma
Copy link
Member

A gateway configuration can be changed at any time. This may affect payment status updates or subscription follow-up payments. It can therefore be nice to save a copy of the gateway configuration in the payment.

Internal Basecamp to-do: https://basecamp.com/1810084/projects/10966871/todos/376801431

Also by making the gateway configurations JSON serializable, we may be able to get rid of the post meta fields in gateway configurations. If we continue to use a custom post type for the gateway configurations, the configuration can be stored completely in post_content with post_mime_type = application/json (as we also do with payments and subscriptions).

@rvdsteege
Copy link
Member

rvdsteege commented Oct 4, 2021

I'm not sure if storing gateway configuration in payments/subscriptions is efficient (we'll end up with a lot of duplicate data, while we are also trying to increase efficiency in other areas) and always desired. Before preparing this in #231.

Let say we add a setting for the subscription recurring payment description and this gets updated, it won't get updated in existing subscriptions (but maybe this should not be a gateway setting in the first place then).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants