From 9e10b7c0ef5a87e6a49058890fbbc0c3b5051f85 Mon Sep 17 00:00:00 2001 From: Sandy Zhang Date: Mon, 28 Oct 2024 09:35:21 -0700 Subject: [PATCH] Fix PHP package.xml generation to generate correct github link to release notes using protoc_version formatted with -rcN instead of -rc-N. Fixes https://github.com/protocolbuffers/protobuf/issues/18979 PiperOrigin-RevId: 690643390 --- php/ext/google/protobuf/generate_package_xml.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/php/ext/google/protobuf/generate_package_xml.sh b/php/ext/google/protobuf/generate_package_xml.sh index 7d4aa94a91df..8fc43dba3fd0 100755 --- a/php/ext/google/protobuf/generate_package_xml.sh +++ b/php/ext/google/protobuf/generate_package_xml.sh @@ -37,5 +37,5 @@ sed -e "s;TEMPLATE_TIME;${time};" | sed -e "s;TEMPLATE_PHP_RELEASE;${release_version};" | sed -e "s;TEMPLATE_PHP_API;${api_version};" | sed -e "s;TEMPLATE_PHP_STABILITY;${stability};g" | -sed -e "s;TEMPLATE_PROTOC_VERSION;${protoc_version};" | +sed -e "s;TEMPLATE_PROTOC_VERSION;${protoc_version//-rc-/-rc};" | sed -e "s;TEMPLATE_FILES;${files};" > $out