diff --git a/e2e/formatters-test.js b/e2e/formatters-test.js index f903f240..c3dd5815 100644 --- a/e2e/formatters-test.js +++ b/e2e/formatters-test.js @@ -131,12 +131,12 @@ describe('e2e', function () { expect(stdout.trim()).to.be.empty expect(stderr).to.include('No files to lint! check glob arguments') }) - it('should return nothing when file exists and there is no error/warning', () => { + it('should return empty array when file exists and there is no error/warning', () => { const { code, stdout } = shell.exec( `${NODE}solhint ${PATH}contracts/Foo3.sol -f ${formatterType}${SUFFIX}` ) expect(code).to.equal(EXIT_CODES.OK) - expect(stdout.trim()).to.be.empty + expect(stdout.trim()).to.equal('[]') }) it('should make the output report with json formatter for Foo2', () => { const { code, stdout } = shell.exec( diff --git a/lib/formatters/json.js b/lib/formatters/json.js index d9bad525..4828538a 100644 --- a/lib/formatters/json.js +++ b/lib/formatters/json.js @@ -58,5 +58,5 @@ module.exports = function (results) { if (finalMessage) allMessages.push(finalMessage) - return allMessages.length > 0 ? JSON.stringify(allMessages) : '' + return JSON.stringify(allMessages) }