From 9590d66e7f26e165601c5fcc4710901b0c415702 Mon Sep 17 00:00:00 2001 From: HugoPBrito Date: Wed, 16 Oct 2024 18:06:50 +0200 Subject: [PATCH] feat: change id for name in status extended --- .../mq_broker_auto_minor_version_upgrades.py | 4 ++-- .../mq_broker_auto_minor_version_upgrades_test.py | 10 ++++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/prowler/providers/aws/services/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades.py b/prowler/providers/aws/services/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades.py index 5ef6105a71..c1cccd8e69 100644 --- a/prowler/providers/aws/services/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades.py +++ b/prowler/providers/aws/services/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades.py @@ -12,11 +12,11 @@ def execute(self): report.resource_arn = broker.arn report.resource_tags = broker.tags report.status = "PASS" - report.status_extended = f"MQ Broker {broker.id} does have automated minor version upgrades enabled." + report.status_extended = f"MQ Broker {broker.name} does have automated minor version upgrades enabled." if not broker.auto_minor_version_upgrade: report.status = "FAIL" - report.status_extended = f"MQ Broker {broker.id} does not have automated minor version upgrades enabled." + report.status_extended = f"MQ Broker {broker.name} does not have automated minor version upgrades enabled." findings.append(report) diff --git a/tests/providers/aws/services/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades_test.py b/tests/providers/aws/services/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades_test.py index 51320ea061..ec71ed56ce 100644 --- a/tests/providers/aws/services/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades_test.py +++ b/tests/providers/aws/services/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades_test.py @@ -38,8 +38,9 @@ def test_no_brokers(self): @mock_aws def test_broker_auto_minor_version_upgrades_enabled(self): mq_client = client("mq", region_name=AWS_REGION_US_EAST_1) + broker_name = "test-broker" broker_id = mq_client.create_broker( - BrokerName="test-broker", + BrokerName=broker_name, EngineType="ACTIVEMQ", EngineVersion="5.15.0", HostInstanceType="mq.t2.micro", @@ -78,7 +79,7 @@ def test_broker_auto_minor_version_upgrades_enabled(self): assert result[0].status == "PASS" assert ( result[0].status_extended - == f"MQ Broker {broker_id} does have automated minor version upgrades enabled." + == f"MQ Broker {broker_name} does have automated minor version upgrades enabled." ) assert result[0].resource_id == broker_id assert ( @@ -90,8 +91,9 @@ def test_broker_auto_minor_version_upgrades_enabled(self): @mock_aws def test_broker_auto_minor_version_upgrades_disabled(self): mq_client = client("mq", region_name=AWS_REGION_US_EAST_1) + broker_name = "test-broker" broker_id = mq_client.create_broker( - BrokerName="test-broker", + BrokerName=broker_name, EngineType="ACTIVEMQ", EngineVersion="5.15.0", HostInstanceType="mq.t2.micro", @@ -130,7 +132,7 @@ def test_broker_auto_minor_version_upgrades_disabled(self): assert result[0].status == "FAIL" assert ( result[0].status_extended - == f"MQ Broker {broker_id} does not have automated minor version upgrades enabled." + == f"MQ Broker {broker_name} does not have automated minor version upgrades enabled." ) assert result[0].resource_id == broker_id assert (