sample rate changes #617
-
|
I've set up a basic a2dp sink on an lolin d32 pro with an adafruit max 98357a. When I first connect with my laptop (Ubuntu 24.04, 48k sample rate), disconnect, and connect with my Pixel 6a (sample rate 44,1K), the test sine of 440hz is being played slightly higher - and vice versa: test tone from my laptop is too low after first connecting with my phone. I guess this means that the i2s sample rate is not really being updated? Or I am missing something? I've read through the issues en discussions here and on the audiotools github, but didn't found anything that could help me out. Latest versions of esp32 core, esp32-a2dp en audiotools libs. |
Beta Was this translation helpful? Give feedback.
Replies: 7 comments 21 replies
-
|
This is the first time I see another sample rate then 44100. I just committed a correction which should resolve this. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @pschatzmann for the swift response. I've pulled from master, but still the same however. If I'm not mistaken, sample rate has been changed to 48k since the switch to pipewire |
Beta Was this translation helpful? Give feedback.
-
|
Then I don't understnd your issue: in your log the sample rate is set to 48000! |
Beta Was this translation helpful? Give feedback.
-
|
yes, but my phone is sending with 44,1k sample rate, thus pitch is higher then it should be. I am not setting sample rates anywhere in my code |
Beta Was this translation helpful? Give feedback.
-
|
I am still confused how this can happen. Do you see the following entry in the log BluetoothA2DPOutput.cpp:217 end()) 15:52:21.917 -> [ 54275][I][BluetoothA2DPOutput.cpp:229] set_sample_rate(): [BT_AV] set_sample_rate 44100 |
Beta Was this translation helpful? Give feedback.
-
|
ps. are you sure that you use an actual version of the audiotools ? |
Beta Was this translation helpful? Give feedback.
-
|
yes, latest version. I've build the bluetooth receiver last week, never used/installed your (great) library before |
Beta Was this translation helpful? Give feedback.
-
|
I'm not seeing the call to end(), no Just tried same code (with your latest commit) on an lolin d32 with a PCM5102 DAC, same there |
Beta Was this translation helpful? Give feedback.
-
|
Maybe you can help me to trace this down: I am expecting that the following line in BluetoothAudioOutput.cpp line 237 |
Beta Was this translation helpful? Give feedback.
-
|
First connection with laptop second connection with phone So, indeed, sample rate is not set when phone connects. I'll add some more debugging |
Beta Was this translation helpful? Give feedback.
-
|
Strange, so after setting it to 48000 it still seems to think that it is ony 44100. Can you check if after the setAudioInfo() with 48000 when you call a getAudioInfo() you get the expected rate or if it is reset later back to 44100 |
Beta Was this translation helpful? Give feedback.
-
Weird. It is not being reset. If I disable the if clause - thus the setAudioInfo being forcefully set, all is working well - perfect pitch, no crackles. So the reporting is faulty? |
Beta Was this translation helpful? Give feedback.
-
|
No, wait, sorry - my bad. It is indeed getting reset to 44100 - though it's still 48k actually |
Beta Was this translation helpful? Give feedback.
-
|
Can you show the log ? |
Beta Was this translation helpful? Give feedback.
-
|
Can you try the following test case which is simulating the scenario and working for me #include "AudioTools.h"
I2SStream i2s;
AudioInfo info1(48000,2,16);
AudioInfo info2(44100,2,16);
void setup() {
Serial.begin(115200);
AudioLogger::instance().begin(Serial, AudioLogger::Info);
// start initial i2s
auto cfg = i2s.defaultConfig();
cfg.copyFrom(info1);
i2s.begin(cfg);
assert(i2s.audioInfo()==info1);
// stop it and set new rate
i2s.end();
Serial.println("--------------------");
i2s.setAudioInfo(info2);
assert(i2s.audioInfo()==info2);
// start it with new rate
i2s.begin();
assert(i2s.audioInfo()==info2);
Serial.println("success");
}
void loop() {
} |
Beta Was this translation helpful? Give feedback.
-
|
Strange: I think I need to have a fresh look tomorrow.. |
Beta Was this translation helpful? Give feedback.
-
|
I have to go also, let me know if I have to debug or test something |
Beta Was this translation helpful? Give feedback.
-
|
I think I finally found it: A2DP uses some adapter classes and those did not forward the audioInfo() to the corresponding class. You need to update the AudioTools to correct this bug. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, that does fix it. Thank you very much! |
Beta Was this translation helpful? Give feedback.
-
|
Hi, pschatzmann and all! Port Monitor Log: My scketch: AudioInfo info(48000, 2, 16); void setup() { //uto config = out.defaultConfig(RXTX_MODE); config.sample_rate = sample_rate; void loop() { |
Beta Was this translation helpful? Give feedback.
-
|
That's not how things work: you need to reasmple using the AudioTools! |
Beta Was this translation helpful? Give feedback.
-
|
TNX! Its running well! |
Beta Was this translation helpful? Give feedback.
-
|
No: TX_MODE is output, RX_MODE is input and RXTX_MODE is douplex. |
Beta Was this translation helpful? Give feedback.
-
|
TNX @pschatzmann ! Resempling working well. #include "AudioTools.h" AudioInfo from_info(44100, 2, 16); void setup() { auto config = out.defaultConfig(TX_MODE); out.begin(config); resample.begin(from_info, to_info.sample_rate); void loop() { |
Beta Was this translation helpful? Give feedback.
-
|
You would just define the pin: on the ESP32 this is usually GPIO 0 |
Beta Was this translation helpful? Give feedback.
-
|
TNX! |
Beta Was this translation helpful? Give feedback.
This is the first time I see another sample rate then 44100.
I just committed a correction which should resolve this.