Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all files (not just targeted files) to be included #1

Open
ebenoist opened this issue Mar 27, 2018 · 0 comments
Open

Allow all files (not just targeted files) to be included #1

ebenoist opened this issue Mar 27, 2018 · 0 comments

Comments

@ebenoist
Copy link

First off, this is a fantastic project. I was able to rewrite a squirrels nest of node code with this library in much fewer lines and the API here took care of a lot of the work I was doing before. Thank you!

One snag I hit was in implementing a compiler for a number of protos from different projects that I'm currently tying together by including each directory in my import path. I can't compile each separately because my target is format that doesn't support imports at all.

Because of the decision to only include those files in the output request, I have to glob all of the protos I have, which break a number of their import resolutions instead of just pointing the compiler at the one entry point proto that imports the rest.

Specifically this decision makes globbing multi project protos difficult. Is there any consideration to making that behavior configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant