Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import time regression #6790

Open
holmanb opened this issue Aug 15, 2024 · 0 comments
Open

Import time regression #6790

holmanb opened this issue Aug 15, 2024 · 0 comments

Comments

@holmanb
Copy link

holmanb commented Aug 15, 2024 •
edited
Loading

Between 2.31.0 and 2.32.3, import time increased by ~25%. This appears to have been caused by #6667, which changed the expensive load_verify_locations() to run at import time (in 2.32.0).

Reproduction Steps

Compare import time of versions with:

$ python3 -X importtime -c 'import requests' 2> requests_import.log
$ tuna requests_import.log

2.31.0

image

2.32.3:

image
@holmanb holmanb mentioned this issue Aug 15, 2024
Open
MindaugasBernatavicius added a commit to MindaugasBernatavicius/requests that referenced this issue Sep 25, 2024
@MindaugasBernatavicius
Solving performance regression psf#6790
abdc7d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@holmanb