Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review all the blocking cache.get() #100

Open
Nuhvi opened this issue Nov 23, 2024 · 0 comments
Open

Review all the blocking cache.get() #100

Nuhvi opened this issue Nov 23, 2024 · 0 comments
Assignees
@Nuhvi

Comments

@Nuhvi
Copy link
Collaborator

Nuhvi commented Nov 23, 2024

We use cache.get() in two places: publish_inner and resolve_inner, which makes every call to them a possible write transaction to the database if LMDB is used for caching.

We should consider using cache.get_read_only instead. And if we never use cache.get() then maybe we can remove it and rename the read only to be just get
@Nuhvi Nuhvi self-assigned this Nov 23, 2024
Nuhvi added a commit that referenced this issue Dec 1, 2024
@Nuhvi
feat(pkarr): add a batch to LmdbCache to close #100 and fix lru bug
9d62e69
@Nuhvi Nuhvi mentioned this issue Dec 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nuhvi Nuhvi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nuhvi