Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't drop stop_times with invalid location_type #5

Open
traines-source opened this issue Feb 25, 2025 · 0 comments
Open

Don't drop stop_times with invalid location_type #5

traines-source opened this issue Feb 25, 2025 · 0 comments

Comments

@traines-source
Copy link
Member

I feel that completely dropping stops from stop_times that have a location_type other than 0 is a bit harsh.

panic(errors.New("Stop " + a.Stop().Id + " (" + a.Stop().Name + ") has location_type != 0, cannot be used in stop_times.txt!"))

While it may be invalid according to the spec, it should not do any great harm to routing or sth. On the contrary, dropping stops from trips does have quite a negative effect. E.g. currently in the DELFI feed for many ICEs heading to Hamburg, which, since Hamburg is dropped, appear to only go till Hanover: https://api.transitous.org/?tripId=20250329_11%3A23_de-DELFI_2766990098 (DELFI feed from 20250224, trip_id 2766990098, stop_id de:02000:10950:5:2549012). There are many more such invalid stops in the current DELFI feed, see mfdz/GTFS-Issues#72.

So I think this should be made optional or just a warning.

@jbruechert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant