Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar and spelling in the wiki #2195

Closed
wdhdev opened this issue Oct 2, 2024 · 6 comments
Closed

Grammar and spelling in the wiki #2195

wdhdev opened this issue Oct 2, 2024 · 6 comments

Comments

@wdhdev
Copy link
Contributor

wdhdev commented Oct 2, 2024

There are quite a lot of typos in the wiki, along with a lot of bad grammar which I think should be fixed just so it is a bit more professional.

I've made a new repo which has a bunch of grammar/spelling/formatting fixes as I couldn't find a way to PR my changes here directly, so it might require a maintainer to manually update the wiki page by page.

Repo: https://github.com/wdhdev/updated-psl-wiki
You can see my updates here: wdhdev/updated-psl-wiki@c284f71

@simon-friedberger
Copy link
Contributor

(N.B. You can actually check out the wiki. You just can't create PRs for it.)

I've had a quick look and found some errors. Maybe make smaller commits so I can cherry-pick?

@wdhdev
Copy link
Contributor Author

wdhdev commented Oct 2, 2024

(N.B. You can actually check out the wiki. You just can't create PRs for it.)

Yeah, that's why I created a separate repo for it.

I've had a quick look and found some errors.

Fixed those.

Maybe make smaller commits so I can cherry-pick?

As in a separate commit for each individual file, or each like individual change?

@simon-friedberger
Copy link
Contributor

Up to your discretion, but if you mix manual changes with a code formatting that breaks things I cannot merge because I don't want to git-select individual hunks.

@wdhdev
Copy link
Contributor Author

wdhdev commented Oct 3, 2024

The code formatter was only updating that text it thought was italic, the rest was done manually.

And for updating the wiki, you should be able to just copy the raw content of each file on the GitHub repo, then just edit the page and overwrite the content on github.com instead of using the CLI.

@dnsguru
Copy link
Member

dnsguru commented Oct 4, 2024

I will read through it. We have used 'edit as you go' method due to resourcing across the decade we were adrift from resources

@simon-friedberger
Copy link
Contributor

I've merged this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants