From 6cb838a3ba710981eac87fcbadc4472fb559bc1f Mon Sep 17 00:00:00 2001 From: Daniel Puckowski Date: Thu, 28 Nov 2024 05:59:38 -0500 Subject: [PATCH] fix(issue:4264) strip line comment from expression * Fix for issue #4264. Strip line comments from expressions to avoid invalid CSS output. --- packages/less/src/less/parser/parser.js | 2 +- packages/test-data/css/_main/variables.css | 15 +++++++++++++++ packages/test-data/less/_main/variables.less | 16 ++++++++++++++++ 3 files changed, 32 insertions(+), 1 deletion(-) diff --git a/packages/less/src/less/parser/parser.js b/packages/less/src/less/parser/parser.js index 59aa2eef4..54ef86a32 100644 --- a/packages/less/src/less/parser/parser.js +++ b/packages/less/src/less/parser/parser.js @@ -2392,7 +2392,7 @@ const Parser = function Parser(context, imports, fileInfo, currentIndex) { do { e = this.comment(); - if (e) { + if (e && !e.isLineComment) { entities.push(e); continue; } diff --git a/packages/test-data/css/_main/variables.css b/packages/test-data/css/_main/variables.css index fa03b1eb7..b0c22c53e 100644 --- a/packages/test-data/css/_main/variables.css +++ b/packages/test-data/css/_main/variables.css @@ -69,3 +69,18 @@ mul-px-2: 140px; mul-px-3: 140px; } +div#apple { + color: blue; +} +div#banana { + color: blue; +} +div#cherry { + color: blue; +} +div#carrot { + color: blue; +} +div#potato { + color: blue; +} diff --git a/packages/test-data/less/_main/variables.less b/packages/test-data/less/_main/variables.less index ae8c9be45..2fcb7977d 100644 --- a/packages/test-data/less/_main/variables.less +++ b/packages/test-data/less/_main/variables.less @@ -125,3 +125,19 @@ mul-px-3: ((@px * 1) * @cm); } } + +@items: +// Fruit + apple, + banana, + cherry, +// Vegetables + carrot, + potato, +; + +each(@items, { + div#@{value} { + color: blue; + } +})