Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent change to logo svg sizing breaks the LuxLibraryFooter #401

Closed
1 task
sdellis opened this issue Dec 2, 2024 · 1 comment
Closed
1 task

Recent change to logo svg sizing breaks the LuxLibraryFooter #401

sdellis opened this issue Dec 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@sdellis
Copy link
Member

sdellis commented Dec 2, 2024

In short, the PUL logo is not being sized correctly in the Library Footer after recent changes resulting in v6.0.0.

Expected behavior

The logo should be smaller and prevent the phone number from running into the University Footer policy links below it.

Actual behavior

See the screenshot included in this ticket: pulibrary/imagecat-rails#267 (review)

Steps to replicate

The oversized logo is visible in the Styleguide, although the phone number doesn't overlap like it does in imagecat.

Impact of this bug

The imagecat upgrade ticket mentioned above is blocked until resolved.

Acceptance criteria

  • If this change touches any of the files referenced in .rubocop_todo.yml create a new ticket to address the rubocop todo.

Implementation notes, if any

Any other components that use the LuxLibraryLogo will be affected due to the changes in the way we size that SVG image. Perhaps worth an implementation note for SVG image sizing going forward.

@sdellis sdellis added the bug Something isn't working label Dec 2, 2024
@christinach
Copy link
Member

@sdellis this ticket seems to be resolved. I'm checking https://imagecat-staging.princeton.edu/
Can I close it?

I've created a new one for the logo size between footer and header.

@sdellis sdellis closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants