You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The oversized logo is visible in the Styleguide, although the phone number doesn't overlap like it does in imagecat.
Impact of this bug
The imagecat upgrade ticket mentioned above is blocked until resolved.
Acceptance criteria
If this change touches any of the files referenced in .rubocop_todo.yml create a new ticket to address the rubocop todo.
Implementation notes, if any
Any other components that use the LuxLibraryLogo will be affected due to the changes in the way we size that SVG image. Perhaps worth an implementation note for SVG image sizing going forward.
The text was updated successfully, but these errors were encountered:
In short, the PUL logo is not being sized correctly in the Library Footer after recent changes resulting in v6.0.0.
Expected behavior
The logo should be smaller and prevent the phone number from running into the University Footer policy links below it.
Actual behavior
See the screenshot included in this ticket: pulibrary/imagecat-rails#267 (review)
Steps to replicate
The oversized logo is visible in the Styleguide, although the phone number doesn't overlap like it does in imagecat.
Impact of this bug
The imagecat upgrade ticket mentioned above is blocked until resolved.
Acceptance criteria
.rubocop_todo.yml
create a new ticket to address the rubocop todo.Implementation notes, if any
Any other components that use the LuxLibraryLogo will be affected due to the changes in the way we size that SVG image. Perhaps worth an implementation note for SVG image sizing going forward.
The text was updated successfully, but these errors were encountered: