Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage notes don't display for all container types #1491

Open
1 task
faithc opened this issue Jan 15, 2025 · 0 comments
Open
1 task

Storage notes don't display for all container types #1491

faithc opened this issue Jan 15, 2025 · 0 comments
Labels
bug Something isn't working dls-work-cycle Tickets designated for the next work cycle (limit 16)

Comments

@faithc
Copy link
Collaborator

faithc commented Jan 15, 2025

Expected behavior

Storage notes should display for all container types present in finding aid data.

Actual behavior

Container information that's associated with the Storage note isn't being populated or displaying at all in cases where containers are identified as items or volumes rather than boxes. See, for example, https://findingaids.princeton.edu/catalog/AC297_c742 and https://findingaids.princeton.edu/catalog/MC006_c00068 where collection materials are indicated as items or volumes as opposed to boxes.

<container altrender="scarcpph" encodinganalog="NBox" id="4e1f0d4e21d48ed64c2d48d529f8cbd5" label="Mixed Materials [32101054257280]" type="item">1978 Brown (Defense 1)</container>

<container altrender="scamudd" encodinganalog="Mudd OS height" id="dc334d21d9fc2e7219478422a1d2d059" label="Mixed Materials [32101105971582]" type="volume">97</container>

For these collections, none of the information for these items/containers displays in the Storage note.

Related to #1302

Steps to replicate

Impact of this bug

Staff and researchers don't know in which location containers are located.

Acceptance criteria

  • If this change touches any of the files referenced in .rubocop_todo.yml create a new ticket to address the rubocop todo.

Honeybadger link and code snippet, if applicable

Implementation notes, if any

@faithc faithc added bug Something isn't working dls-work-cycle Tickets designated for the next work cycle (limit 16) labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dls-work-cycle Tickets designated for the next work cycle (limit 16)
Projects
None yet
Development

No branches or pull requests

1 participant