Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible protocol violation #37

Open
mp-17 opened this issue May 12, 2023 · 1 comment
Open

Possible protocol violation #37

mp-17 opened this issue May 12, 2023 · 1 comment

Comments

@mp-17
Copy link

mp-17 commented May 12, 2023

Hello folks,

We have spotted a timing loop when using the reg_to_tlul.sv module.

It seems that we have a ready -> valid dependency here:

assign tl_o.a_valid = reg_req_i.valid & tl_i.a_ready;

From a super quick look, I think we can just drop the & tl_i.a_ready masking.

assign tl_o.a_valid    = reg_req_i.valid;

Thank you, and let us know! ;-)
Matteo

@paulsc96
Copy link
Collaborator

Finders, keepers :) I suggest you open a PR for this so you are credited with fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants