From 272d34ebc85c787c0fb86d376a528f2ca392d66a Mon Sep 17 00:00:00 2001
From: Luca Colagrande <bigcola.96@gmail.com>
Date: Wed, 21 Feb 2024 13:22:45 +0100
Subject: [PATCH] target: Move `.rtlbinary` to `SIM_DIR`

---
 .github/workflows/ci.yml |  2 +-
 .gitlab-ci.yml           |  2 +-
 target/common/common.mk  | 11 +++++------
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7b7b92cb8b..5351680a4c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -48,7 +48,7 @@ jobs:
       - name: Annotate traces
         working-directory: target/snitch_cluster
         run: |
-          make LOGS_DIR=./runs/simple/logs annotate -j
+          make SIM_DIR=./runs/simple annotate -j
 
   # Tests requiring hardware FDIV unit
   sw-snitch-cluster-fdiv-vlt:
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 946426fd71..91cb6fedb9 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -102,7 +102,7 @@ snitch-cluster-vsim:
     - cd target/snitch_cluster
     - make bin/snitch_cluster.vsim
     - ./run.py sw/run.yaml --simulator vsim -j --run-dir runs/vsim
-    - make LOGS_DIR=./runs/vsim/simple/logs annotate -j
+    - make SIM_DIR=./runs/vsim/simple annotate -j
 
 # Banshee
 snitch-cluster-banshee:
diff --git a/target/common/common.mk b/target/common/common.mk
index 6b7c45be01..a7970a9a19 100644
--- a/target/common/common.mk
+++ b/target/common/common.mk
@@ -6,9 +6,10 @@
 DEBUG ?= OFF  # ON to turn on wave logging
 
 # Directories
-LOGS_DIR ?= logs
+SIM_DIR  ?= $(shell pwd)
 TB_DIR   ?= $(SNITCH_ROOT)/target/common/test
 UTIL_DIR ?= $(SNITCH_ROOT)/util
+LOGS_DIR  = $(SIM_DIR)/logs
 
 # SEPP packages
 QUESTA_SEPP    ?=
@@ -184,16 +185,14 @@ define QUESTASIM
 	@mkdir -p $(dir $@)
 	@echo "#!/bin/bash" > $@
 	@echo 'binary=$$(realpath $$1)' >> $@
-	@echo 'mkdir -p $(LOGS_DIR)' >> $@
-	@echo 'echo $$binary > $(LOGS_DIR)/.rtlbinary' >> $@
+	@echo 'echo $$binary > .rtlbinary' >> $@
 	@echo '${VSIM} +permissive ${VSIM_FLAGS} $$3 -work ${MKFILE_DIR}/${VSIM_BUILDDIR} -c \
 				-ldflags "-Wl,-rpath,${FESVR}/lib -L${FESVR}/lib -lfesvr -lutil" \
 				$(1)_opt +permissive-off ++$$binary ++$$2' >> $@
 	@chmod +x $@
 	@echo "#!/bin/bash" > $@.gui
 	@echo 'binary=$$(realpath $$1)' >> $@.gui
-	@echo 'mkdir -p $(LOGS_DIR)' >> $@.gui
-	@echo 'echo $$binary > $(LOGS_DIR)/.rtlbinary' >> $@.gui
+	@echo 'echo $$binary > .rtlbinary' >> $@.gui
 	@echo '${VSIM} +permissive ${VSIM_FLAGS} -work ${MKFILE_DIR}/${VSIM_BUILDDIR} \
 				-ldflags "-Wl,-rpath,${FESVR}/lib -L${FESVR}/lib -lfesvr -lutil" \
 				$(1)_opt +permissive-off ++$$binary ++$$2' >> $@.gui
@@ -257,7 +256,7 @@ $(LOGS_DIR)/trace_hart_%.txt $(LOGS_DIR)/hart_%_perf.json: $(LOGS_DIR)/trace_har
 
 # Generate source-code interleaved traces for all harts. Reads the binary from
 # the logs/.rtlbinary file that is written at start of simulation in the vsim script
-BINARY ?= $(shell cat $(LOGS_DIR)/.rtlbinary)
+BINARY ?= $(shell cat $(SIM_DIR)/.rtlbinary)
 $(LOGS_DIR)/trace_hart_%.s: $(LOGS_DIR)/trace_hart_%.txt ${ANNOTATE_PY}
 	$(PYTHON) ${ANNOTATE_PY} ${ANNOTATE_FLAGS} -o $@ $(BINARY) $<
 $(LOGS_DIR)/trace_hart_%.diff: $(LOGS_DIR)/trace_hart_%.txt ${ANNOTATE_PY}