Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies with handling of /users endpoints #80

Open
5 tasks done
savetheclocktower opened this issue Feb 24, 2023 · 5 comments
Open
5 tasks done

Inconsistencies with handling of /users endpoints #80

savetheclocktower opened this issue Feb 24, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@savetheclocktower
Copy link
Contributor

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

Even when I'm logged in as myself (savetheclocktower), the /users/savetheclocktower endpoint returns a 404. This is fine, except that the package listings inside Pulsar's settings link the package author's username to https://web.pulsar-edit.dev/users/[user]. (That should probably change anyway and link directly to the author's GitHub profile.)

The /users endpoint is what is linked under “My Account” on the top navigation, and properly shows my username and API token. But the /users/ endpoint (with a trailing slash) shows this instead:

Screen Shot 2023-02-23 at 10 08 52 PM

Pulsar version

(doesn't matter)

Which OS does this happen on?

🍎 macOS

OS details

(doesn't matter)

Which CPU architecture are you running this on?

None

What steps are needed to reproduce this?

(the things I described above)

Additional Information:

Man, this issue template probably should be different from the ones in the other Pulsar repos. :-)

@savetheclocktower savetheclocktower added the bug Something isn't working label Feb 24, 2023
@confused-Techie
Copy link
Member

So taking a look at this, a quick note, we do actually have an issue template just for website based issues, like the frontend or GitHub pages site

image

Otherwise, yeah forgot that's how Pulsar links to users. Those endpoints should be functional on the actual API, but the frontend doesn't pass them along. So we would need to start doing that.

IIRC the way it's structured is already compatible, with the users endpoint supposed to be returning your current user, then having a username on the path is a lookup.

As for the inaccurate placeholder user showing on users/ that looks like a bug in the frontend JavaScript. So would need to be looked at there, but thanks for pointing all this out.

I'd probably be the happiest trying to get the frontend to pass along users/:userName queries sooner rather than later

@savetheclocktower
Copy link
Contributor Author

So taking a look at this, a quick note, we do actually have an issue template just for website based issues, like the frontend or GitHub pages site

That'll teach me to read too quickly!

@savetheclocktower
Copy link
Contributor Author

Bumping this because I'm wanting a list of all my own packages to use when responding to discussions. It'd be great if clicking on any single user took you to a list of that user's packages.

@confused-Techie
Copy link
Member

I hear your bump, and am reputting it on the todo list, sorry it's been open for nearly a year now. I'll try to make sure it doesn't actually hit the year mark

@savetheclocktower
Copy link
Contributor Author

S'ok, I'll probably work on it myself sometime this week or next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants