Fix and simplify 'make prebuild' to fix master workflow #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3097 +/- ##
==========================================
- Coverage 60.96% 60.90% -0.07%
==========================================
Files 70 70
Lines 11274 11274
==========================================
- Hits 6873 6866 -7
- Misses 3840 3847 +7
Partials 561 561 ☔ View full report in Codecov by Sentry. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
iwahbe
approved these changes
Feb 21, 2024
thomas11
added a commit
that referenced
this pull request
Mar 25, 2024
This is a regression that I introduced in #3097. This PR reworks the `prebuild` target to work the same way other targets like `provider_prebuild` work, using a local marker file to track state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3092
Successful master build