Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert unreleased spec updates to get Wheel size below 100m #3988

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

thomas11
Copy link
Contributor

Also reverts "Re-compress the Python Wheel package with bzip2 to shave off 7 MB. (#3982)" which didn't work because Pypi doesn't accept bzip2 even though the Wheel standard allows it.

Copy link

github-actions bot commented Feb 26, 2025

Does the PR have any schema changes?

Found 87 breaking changes:

Resources

  • 🔴 "azure-native:advisor:Assessment" missing
  • 🔴 "azure-native:agricultureplatform:AgriService" missing
  • 🔴 "azure-native:databasefleetmanager:FirewallRule" missing
  • 🔴 "azure-native:databasefleetmanager:Fleet" missing
  • 🔴 "azure-native:databasefleetmanager:FleetDatabase" missing
  • 🔴 "azure-native:databasefleetmanager:FleetTier" missing
  • 🔴 "azure-native:databasefleetmanager:Fleetspace" missing
  • 🔴 "azure-native:dependencymap:DiscoverySource" missing
  • 🔴 "azure-native:dependencymap:Map" missing
  • "azure-native:hybridconnectivity:PublicCloudConnector":
    • inputs:
      • 🟡 "awsCloudProfile" missing
      • 🟡 "hostType" missing
    • properties:
      • 🟡 "awsCloudProfile" missing output "awsCloudProfile"
      • 🟡 "connectorPrimaryIdentifier" missing output "connectorPrimaryIdentifier"
      • 🟡 "hostType" missing output "hostType"
      • 🟡 "provisioningState" missing output "provisioningState"
  • "azure-native:hybridconnectivity:SolutionConfiguration":
    • inputs:
      • 🟡 "solutionSettings" missing
      • 🟡 "solutionType" missing
    • properties:
      • 🟡 "lastSyncTime" missing output "lastSyncTime"
      • 🟡 "provisioningState" missing output "provisioningState"
      • 🟡 "solutionSettings" missing output "solutionSettings"
      • 🟡 "solutionType" missing output "solutionType"
      • 🟡 "status" missing output "status"
      • 🟡 "statusDetails" missing output "statusDetails"

Functions

  • 🔴 "azure-native:advisor:getAssessment" missing
  • 🔴 "azure-native:agricultureplatform:getAgriService" missing
  • 🔴 "azure-native:agricultureplatform:listAgriServiceAvailableSolutions" missing
  • 🔴 "azure-native:databasefleetmanager:getFirewallRule" missing
  • 🔴 "azure-native:databasefleetmanager:getFleet" missing
  • 🔴 "azure-native:databasefleetmanager:getFleetDatabase" missing
  • 🔴 "azure-native:databasefleetmanager:getFleetTier" missing
  • 🔴 "azure-native:databasefleetmanager:getFleetspace" missing
  • 🔴 "azure-native:dependencymap:getDiscoverySource" missing
  • 🔴 "azure-native:dependencymap:getMap" missing

Types

  • 🔴 "azure-native:agricultureplatform:AgriServiceConfigResponse" missing
  • 🔴 "azure-native:agricultureplatform:AgriServiceResourceProperties" missing
  • 🔴 "azure-native:agricultureplatform:AgriServiceResourcePropertiesResponse" missing
  • 🔴 "azure-native:agricultureplatform:AuthCredentialsKind" missing
  • 🔴 "azure-native:agricultureplatform:DataConnectorCredentialMap" missing
  • 🔴 "azure-native:agricultureplatform:DataConnectorCredentialMapResponse" missing
  • 🔴 "azure-native:agricultureplatform:DataConnectorCredentials" missing
  • 🔴 "azure-native:agricultureplatform:DataConnectorCredentialsResponse" missing
  • 🔴 "azure-native:agricultureplatform:DataManagerForAgricultureSolutionResponse" missing
  • 🔴 "azure-native:agricultureplatform:InstalledSolutionMap" missing
  • 🔴 "azure-native:agricultureplatform:InstalledSolutionMapResponse" missing
  • 🔴 "azure-native:agricultureplatform:ManagedOnBehalfOfConfigurationResponse" missing
  • 🔴 "azure-native:agricultureplatform:ManagedServiceIdentity" missing
  • 🔴 "azure-native:agricultureplatform:ManagedServiceIdentityResponse" missing
  • 🔴 "azure-native:agricultureplatform:ManagedServiceIdentityType" missing
  • 🔴 "azure-native:agricultureplatform:MarketPlaceOfferDetailsResponse" missing
  • 🔴 "azure-native:agricultureplatform:MoboBrokerResourceResponse" missing
  • 🔴 "azure-native:agricultureplatform:Sku" missing
  • 🔴 "azure-native:agricultureplatform:SkuResponse" missing
  • 🔴 "azure-native:agricultureplatform:SkuTier" missing
  • 🔴 "azure-native:agricultureplatform:Solution" missing
  • 🔴 "azure-native:agricultureplatform:SolutionResponse" missing
  • 🔴 "azure-native:agricultureplatform:SystemDataResponse" missing
  • 🔴 "azure-native:agricultureplatform:UserAssignedIdentityResponse" missing
  • 🔴 "azure-native:databasefleetmanager:DatabaseCreateMode" missing
  • 🔴 "azure-native:databasefleetmanager:DatabaseIdentity" missing
  • 🔴 "azure-native:databasefleetmanager:DatabaseIdentityResponse" missing
  • 🔴 "azure-native:databasefleetmanager:FirewallRuleProperties" missing
  • 🔴 "azure-native:databasefleetmanager:FirewallRulePropertiesResponse" missing
  • 🔴 "azure-native:databasefleetmanager:FleetDatabaseProperties" missing
  • 🔴 "azure-native:databasefleetmanager:FleetDatabasePropertiesResponse" missing
  • 🔴 "azure-native:databasefleetmanager:FleetProperties" missing
  • 🔴 "azure-native:databasefleetmanager:FleetPropertiesResponse" missing
  • 🔴 "azure-native:databasefleetmanager:FleetTierProperties" missing
  • 🔴 "azure-native:databasefleetmanager:FleetTierPropertiesResponse" missing
  • 🔴 "azure-native:databasefleetmanager:FleetspaceProperties" missing
  • 🔴 "azure-native:databasefleetmanager:FleetspacePropertiesResponse" missing
  • 🔴 "azure-native:databasefleetmanager:Identity" missing
  • 🔴 "azure-native:databasefleetmanager:IdentityResponse" missing
  • 🔴 "azure-native:databasefleetmanager:IdentityType" missing
  • 🔴 "azure-native:databasefleetmanager:MainPrincipal" missing
  • 🔴 "azure-native:databasefleetmanager:MainPrincipalResponse" missing
  • 🔴 "azure-native:databasefleetmanager:PrincipalType" missing
  • 🔴 "azure-native:databasefleetmanager:SystemDataResponse" missing
  • 🔴 "azure-native:databasefleetmanager:TransparentDataEncryption" missing
  • 🔴 "azure-native:databasefleetmanager:TransparentDataEncryptionResponse" missing
  • 🔴 "azure-native:databasefleetmanager:ZoneRedundancy" missing
  • 🟢 "azure-native:datafactory:OracleLinkedService": required: "connectionString" property has changed to Required
  • 🟢 "azure-native:datafactory:OracleLinkedServiceResponse": required: "connectionString" property has changed to Required
  • 🔴 "azure-native:dependencymap:ProcessNameFilterOperator" missing
  • 🔴 "azure-native:dependencymap:SourceType" missing
  • 🔴 "azure-native:dependencymap:SystemDataResponse" missing
  • 🟢 "azure-native:sovereign:LandingZoneRegistrationResourceProperties": required: "managedIdentity" property has changed to Required
  • 🟢 "azure-native:sovereign:LandingZoneRegistrationResourcePropertiesResponse": required: "managedIdentity" property has changed to Required
    No new resources/functions.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.50%. Comparing base (6196cc4) to head (c14d4f1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3988      +/-   ##
==========================================
- Coverage   57.51%   57.50%   -0.01%     
==========================================
  Files          82       82              
  Lines       13092    13092              
==========================================
- Hits         7530     7529       -1     
- Misses       4986     4987       +1     
  Partials      576      576              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than reverting the whole spec upgrade, I think we previously just started adding exclusions so we get updates & fixes to the existing resource versions we're already using, but don't add any new resources to the SDK.

@thomas11
Copy link
Contributor Author

Rather than reverting the whole spec upgrade, I think we previously just started adding exclusions so we get updates & fixes to the existing resource versions we're already using, but don't add any new resources to the SDK.

True. That seems like a bunch of extra work for a hopefully short-lived situation, though. We can still do a future release with such updates if we need it, which I think isn't very likely.

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is fine to make the provider releasable as-is to get the associated fixes released. We can re-visit pinning next week if needed.

@thomas11 thomas11 merged commit c8d7635 into master Feb 26, 2025
27 of 39 checks passed
@thomas11 thomas11 deleted the tkappler/exclude-new branch February 26, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants