-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert unreleased spec updates to get Wheel size below 100m #3988
Conversation
Does the PR have any schema changes?Found 87 breaking changes: Resources
Functions
Types
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3988 +/- ##
==========================================
- Coverage 57.51% 57.50% -0.01%
==========================================
Files 82 82
Lines 13092 13092
==========================================
- Hits 7530 7529 -1
- Misses 4986 4987 +1
Partials 576 576 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than reverting the whole spec upgrade, I think we previously just started adding exclusions so we get updates & fixes to the existing resource versions we're already using, but don't add any new resources to the SDK.
True. That seems like a bunch of extra work for a hopefully short-lived situation, though. We can still do a future release with such updates if we need it, which I think isn't very likely. |
b3f4540
to
c14d4f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, this is fine to make the provider releasable as-is to get the associated fixes released. We can re-visit pinning next week if needed.
Also reverts "Re-compress the Python Wheel package with bzip2 to shave off 7 MB. (#3982)" which didn't work because Pypi doesn't accept bzip2 even though the Wheel standard allows it.