Run build & test steps on windows & macos if the ci/test label is set #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienp
force-pushed
the
julienp/run-build-test-label
branch
9 times, most recently
from
4831c7f to
61393ef
Compare
Frassle
reviewed
Jan 29, 2024
julienp
force-pushed
the
julienp/run-build-test-label
branch
5 times, most recently
from
c4adea2 to
60ebcb5
Compare
julienp
force-pushed
the
julienp/run-build-test-label
branch
3 times, most recently
from
a963451 to
05cc51a
Compare
julienp
force-pushed
the
julienp/run-build-test-label
branch
4 times, most recently
from
dc96cc5 to
ff6e0f7
Compare
julienp
added
the
impact/no-changelog-required
tgummerer
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
I think https://github.com/pulumi/pulumi-dotnet/pull/227/files#diff-15c806aa509538190832852f439e9921a23bec2da81f95ed0e4bf13c14e5b160R146 now also needs a dependency on format. Other than that this LGTM!
julienp
force-pushed
the
julienp/run-build-test-label
branch
from
ff6e0f7 to
bb8efee
Compare
We don't want it to complain about line endings on windows.
julienp
force-pushed
the
julienp/run-build-test-label
branch
from
bb8efee to
fa04622
Compare
jkerken
pushed a commit
to algompluecker/pulumi-dotnet
that referenced
this pull request
Jul 24, 2024
…pulumi#227) * Run build & test steps on windows & macos if the ci/test label is set * Only run formatting check on linux We don't want it to complain about line endings on windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only run a certain integration tests on windows & Mac.
Allow running the sdk and automation tests on windows & Mac by setting the
ci/testlabel.