Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Ability to add/modify labels on a service #76

Open
ColeSiegelTR opened this issue May 3, 2022 · 2 comments
Open

Ability to add/modify labels on a service #76

ColeSiegelTR opened this issue May 3, 2022 · 2 comments
Labels
kind/enhancement Improvements or new features

Comments

@ColeSiegelTR
Copy link

Hi,

I'd like to add labels to my kubernetes service, but I don't see this available in kx.Deployment.createService

I tried to work around it with the code below but it had no effect:

service.metadata.labels = {
            ...this.service.metadata.labels,
            "app": this.name
        } as any;

Any suggestions? Lots of other features require specific labels to be set on the service, for scoping purposes.

Thanks in advance!

@ColeSiegelTR ColeSiegelTR added the kind/enhancement Improvements or new features label May 3, 2022
@ColeSiegelTR ColeSiegelTR changed the title Ability to add/modify labels on a service? Ability to add/modify labels on a service May 3, 2022
@ColeSiegelTR
Copy link
Author

Or if the service can inherit labels from deployment somehow, this would also solve my problem

@stack72 stack72 added kind/enhancement Improvements or new features and removed kind/enhancement Improvements or new features labels May 9, 2022
@cdgn-coding
Copy link

Hi, this would be a very useful feature for ClusterIP services. I wonder if the owners are open for a pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

3 participants