-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login message tweak #28
base: main
Are you sure you want to change the base?
Conversation
@@ -307,7 +307,7 @@ | |||
"viewsWelcome": [ | |||
{ | |||
"view": "pulumi-esc-explorer", | |||
"contents": "Welcome to Pulumi ESC! You will now be able to view and modify your ESC Environments inside VSCode. To get started, login to Pulumi Cloud. \n[Login to Pulumi](command:pulumi.login)." | |||
"contents": "Welcome to Pulumi ESC! You will now be able to view and modify your ESC Environments inside VSCode. To get started, connect to Pulumi Cloud. \n[Connect to Pulumi Cloud](command:pulumi.login)\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this really disambiguates anything. connect vs login is a subtle difference that customers may not understand. What if instead of calling esc.refresh (which often cannot really refresh because it has not been authenticated, we create a new command in esc that sets state we can use in the "when" block to show a special welcome view indicating that the user needs to authorize to use the existing login established by the copilot extension. If that is not set it would show this welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simply think this is a problem that is inherent to vscode, and exists even without other extensions being involved. For example:
Screen.Recording.2025-01-31.at.12.52.08.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but personally I am not sure people are using the accounts UX that often, and if they do they may understand. I am not sure they understand why the login between Copilot and ESC appears to not be shared. I would really like this be as seamless as possible. Can you respond to my last comment about a possible solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a doubt that your solution (of having the copilot extension send a hint to the esc extension) would work across vscode windows. I observe that auth session and extension trust settings are profile-wide.
I do think the current solution is pretty seamless. When they click Connect on the ESC sidebar, the extension becomes trusted and the user is not asked to re-login.
a821cea
to
51658c6
Compare
Tweaks the message for the edge case where the user is already signed in and the extension is simply lacking trust. There's no way to disambiguate those cases, so we relax the wording.
Also, changed the link to a button for consistency with other explorers, which resemble: