Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login message tweak #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Login message tweak #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8211ab5
login message tweak
EronWright Jan 31, 2025
51658c6
changelog
EronWright Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
- Fix for debugging with a self-managed backend #20
- Extension should install the latest CLI #12
- Add Pulumi Copilot to extension pack
- New welcome text for the ESC Explorer

## v0.1.0
- Initial release
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@
"viewsWelcome": [
{
"view": "pulumi-esc-explorer",
"contents": "Welcome to Pulumi ESC! You will now be able to view and modify your ESC Environments inside VSCode. To get started, login to Pulumi Cloud. \n[Login to Pulumi](command:pulumi.login)."
"contents": "Welcome to Pulumi ESC! You will now be able to view and modify your ESC Environments inside VSCode. To get started, connect to Pulumi Cloud. \n[Connect to Pulumi Cloud](command:pulumi.login)\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this really disambiguates anything. connect vs login is a subtle difference that customers may not understand. What if instead of calling esc.refresh (which often cannot really refresh because it has not been authenticated, we create a new command in esc that sets state we can use in the "when" block to show a special welcome view indicating that the user needs to authorize to use the existing login established by the copilot extension. If that is not set it would show this welcome.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply think this is a problem that is inherent to vscode, and exists even without other extensions being involved. For example:

Screen.Recording.2025-01-31.at.12.52.08.PM.mov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but personally I am not sure people are using the accounts UX that often, and if they do they may understand. I am not sure they understand why the login between Copilot and ESC appears to not be shared. I would really like this be as seamless as possible. Can you respond to my last comment about a possible solution.

Copy link
Collaborator Author

@EronWright EronWright Feb 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a doubt that your solution (of having the copilot extension send a hint to the esc extension) would work across vscode windows. I observe that auth session and extension trust settings are profile-wide.

I do think the current solution is pretty seamless. When they click Connect on the ESC sidebar, the extension becomes trusted and the user is not asked to re-login.

}
],
"debuggers": [
Expand Down