Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize large images during crop step #23

Open
MatthewStanciu opened this issue Feb 8, 2024 · 1 comment
Open

Resize large images during crop step #23

MatthewStanciu opened this issue Feb 8, 2024 · 1 comment

Comments

@MatthewStanciu
Copy link
Member

Some images uploaded via iOS Safari are scaled to be very large (10,000 pixels!). The maximum canvas size on iOS is 4096x4096, so an image this large breaks the canvas and causes the cropping step to silently fail.
@MatthewStanciu MatthewStanciu mentioned this issue Feb 8, 2024
Closed
MatthewStanciu added a commit that referenced this issue Feb 8, 2024
@MatthewStanciu
Remove pixelRatio
db9c854 
This gets closer to fixing #23, but doesn't prevent large images
@MatthewStanciu MatthewStanciu mentioned this issue Feb 8, 2024
Merged
@MatthewStanciu
Copy link
Member Author

Removing the launch blocker label since the biggest issue was fixed in #24. But very large images should still either be resized or prevented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MatthewStanciu