Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy List's mapWithIndex is not lazy #218

Open
worldmaker18349276 opened this issue Aug 2, 2024 · 0 comments
Open

Lazy List's mapWithIndex is not lazy #218

worldmaker18349276 opened this issue Aug 2, 2024 · 0 comments

Comments

@worldmaker18349276
Copy link

mapWithIndex f = foldrWithIndex (\i x acc -> f i x : acc) nil

The implementation of FunctorWithIndex for Lazy List uses folding, which, unlike Functor, is not lazy.

It should be:

instance functorWithIndexList :: FunctorWithIndex Int List where
  mapWithIndex f xs = List (go 0 <$> unwrap xs)
    where
    go i = \step -> case step of
      Nil -> Nil
      Cons x xs' -> Cons (f i x) (List (go (i + 1) <$> unwrap xs'))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant