Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data retrieval doesn't return the same dates for test #8

Open
pwdemars opened this issue Jul 8, 2022 · 0 comments
Open

Data retrieval doesn't return the same dates for test #8

pwdemars opened this issue Jul 8, 2022 · 0 comments

Comments

@pwdemars
Copy link
Owner

pwdemars commented Jul 8, 2022

In data_retrieval.py the SEED variable is defined but not used to set a random seed. The subset of days held out for testing therefore differs each time the script is run.

Probably easier to just define the test days manually to be honest. Those used in publications are:

['2016-01-12',
 '2016-07-25',
 '2016-11-21',
 '2017-03-18',
 '2017-04-07',
 '2017-05-12',
 '2017-05-26',
 '2017-06-25',
 '2017-12-18',
 '2017-12-30',
 '2018-01-15',
 '2018-03-08',
 '2018-03-18',
 '2018-05-30',
 '2018-09-11',
 '2018-11-13',
 '2019-04-03',
 '2019-05-22',
 '2019-10-30',
 '2019-11-09']
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant