Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "test" script + instructions #15

Open
ljharb opened this issue Aug 3, 2016 · 2 comments
Open

Add "test" script + instructions #15

ljharb opened this issue Aug 3, 2016 · 2 comments

Comments

@ljharb
Copy link
Collaborator

ljharb commented Aug 3, 2016

I figured out that mocha will run the tests, but 5 of them fail with "Error: Forbidden". Do I have to set up environment variables for the tests to pass?

It looks like GITHUB_OAUTH_TOKEN, GITHUB_USERNAME, and GITHUB_PASSWORD are what the tests expect, but that should probably be documented (and there should probably be explicit tests that fail when these env vars are not defined.

@ljharb
Copy link
Collaborator Author

ljharb commented Aug 4, 2016

Also, my github account uses 2FA - does that mean it can't work with this lib?

@JuanCaicedo
Copy link

@ljharb for what it's worth, I think if you have a github oauth token you don't need to provide them with 2FA. I'm working with this problem now as well 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants