Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to view the dealt damage type #217

Open
simonszu opened this issue Dec 8, 2014 · 3 comments
Open

How to view the dealt damage type #217

simonszu opened this issue Dec 8, 2014 · 3 comments
Labels
enhancement This is a feature request, or an idea to enhancement a current feature

Comments

@simonszu
Copy link

simonszu commented Dec 8, 2014

Hi,

i think this can be marked as a feature request: There seems to be no possibility to view the damage type dealt. I understand that this is no problem when you just carry different types of munitions, but there are also different damage types dealt by drones, and maybe one wants to create a fit which deals all damage types equally, and he needs drones to fill a typegap.

@blitzmann
Copy link
Collaborator

This is a good idea, however the problem is with how to display it. We could display it in the same vain as we display incoming damage - a single line in firepower with EM, Therm, Exp, and Kin gauges showing percentage of those damage types currently being applied.

There are two problems with that however:

  1. Vertical space. pyfa is at it's limits with respect to minimum vertical space we can expect to achieve. Adding a gauge bar like this would increase the vertical space another 30px or so.
  2. A gauge bar like this might be confused with the target resists applied.

We could do a three way toggle Firepower -> Damage Types -> Mining Amount, tho this seems messy and non-intuitive. I would love to hear more about possibilities on where to put this information. The information is there, just needs to be displayed.

EDIT: quick mockup of what my idea might look like: http://gyazo.com/203c8e2a9ba82e18cb705e787b6937ed

And toggling to mining view leaves the space the gauges take as blank (does not resize to fit the mining amount panel, due to various limitations)

@blitzmann
Copy link
Collaborator

Considering space issues, I think it would be best to include this info in the tooltip for firepower information. Maybe something as simple as:

EM: 56%
THERM: 44%

We just don't really have the space for it in the UI unless someone comes up with a good place for it.

@DarkFenX
Copy link
Member

DarkFenX commented Dec 12, 2018

FYI i added support on the backend side. Now damage type info is exposed to UI: https://github.com/pyfa-org/Pyfa/blob/master/gui/builtinStatsViews/firepowerViewFull.py#L161

Here, UI uses .total, but can fetch .em, .thermal, .kinetic or .explosive. as needed.

UI-wise, i think it could be done as relatively thin horizontal stripe below DPS bar, with colors depicting damage types (em - blue, thermal - red, kinetic - gray, explosive - yellow).

@DarkFenX DarkFenX added the enhancement This is a feature request, or an idea to enhancement a current feature label Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a feature request, or an idea to enhancement a current feature
Projects
None yet
Development

No branches or pull requests

3 participants