-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat req] ability to have stat window permanently visible and reacting to selected items #417
Comments
What would be the use-case here? Most of the important attributes that you would want to see are already on the fitting window, what would be the need to see the large list of attributes pyfa keeps track of every time you click another module? |
It makes comparison between certain modules much easier and faster - by just moving cursor over them. For example take deadspace modules: 2-3 groups * C-/B-/A-/X- can get tiring when we need to RMB, select "show module stats", close, repeat with next. It could also help with main fit window - even if it's notably more information rich than EFT's, sometimes we want to check other stuff (or just stuff not explicitly informed - e.g. armor hardeners resistance bonus). |
This is already handled in a very neat fashion with the compare tab that @blitzmann has added. The issue here is the way that wxPython handles GUI updates. You would have to build the window and call out to update it every time, this will slow down the GUI refresh process (which is already slow enough that you can watch it refresh). There's a couple ways we could handle this in wxPython, but it's really hacky and not a great solution due to the refresh issue. I think this is better handled with general UI improvements, the item compare was a massive step in that direction (BTW, did you know it works on Ships too?) and a fit compare would be as well. @blitzmann as we already have a few open issues regarding fit compares, and you do have the item compare in place, can we close this? |
Thinking back on this... I think it could be possible... Imagine: A checkbox on the lower end of the item stats window that toggles "Bind to currently selected item". This will cause the window to remain in place, and listen for item selected events.When the event happens, it updates. I don't think it's too difficult, or will cause any performance issues. I will definitely have to check into it a bit further though to make sure it's feasible, but it's an intriguing idea. |
As far as I know with wxPython you'll have to create bindings for all the fields you want to update, and then you'll have to refresh those every single time. That's going to add a LOT of bindings. Hmm....what if we added a refresh button that reloaded the existing item window. Wouldn't be instant, but you click it and it updates. Might be easier to implement, given wxPython's limitations. Pyfa is noticeably slow on refreshing the GUI, and it gets pretty bad if you have complex fits up with lots of things going on. I'm just concerned about dumping a bunch of stuff on top of it, since it's not unusual to have second+ delays doing normal operations currently. |
Nope. Those fields are set to the item passed to the window. All we need to do is change the item, we basically just need to do the same thing, but on the selection of an item instead of a ctrl+click open stats. :)
I know you don't like wx, and I'll admit it's given me more headaches than I can count, but it is a pretty powerful GUI toolkit. I wouldn't underestimate it's abilities once you're familiar with it. I'll try to build out this feature soon. I don't think performance will be an issue, but we'll see. |
Good luck. o7 |
Btw, as an orignal reporter of this "issue" - just wanted to mention I got used to comparison tab, as per earlier comment:
TBH it's probably more convenient than for what I asked originally - so feel free to close this issue |
I'll keep it open, if anything due to sheer curiosity if it can be done as easily as I think. It's also a feature that has come up a few times before, so some folks want it. :) |
Essentially equivalent of "selected item info" under EFT. E.g.:

The text was updated successfully, but these errors were encountered: