Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do list for 2.14.0 #5513

Closed
14 of 15 tasks
DanielNoord opened this issue Dec 13, 2021 · 12 comments · Fixed by #6785
Closed
14 of 15 tasks

To-do list for 2.14.0 #5513

DanielNoord opened this issue Dec 13, 2021 · 12 comments · Fixed by #6785
Labels
Blocker 🙅 Blocks the next release Maintenance Discussion or action around maintaining pylint or the dev workflow
Milestone

Comments

@DanielNoord
Copy link
Collaborator

DanielNoord commented Dec 13, 2021

TODO:

Potentially:

@DanielNoord DanielNoord added Blocker 🙅 Blocks the next release Maintenance Discussion or action around maintaining pylint or the dev workflow labels Dec 13, 2021
@DanielNoord DanielNoord added this to the 2.14.0 milestone Dec 13, 2021
@DanielNoord
Copy link
Collaborator Author

I'm adding to this that https://bugs.python.org/issue33053 seems to have been fixed in 3.7. We mention that issue in here:
https://github.com/PyCQA/pylint/blob/019794b808271d45f86a7014e9c91cb04458a47a/pylint/__init__.py#L56

We need to update the docstring to reflect whatever the situation in 3.7+ is.

@cdce8p
Copy link
Member

cdce8p commented Dec 30, 2021

We could also consider if we want to require 3.7.2 instead of 3.7.0. That would prevent any upcoming issues with NoReturn. Just to be clear though, the current code works with 3.7.0 just fine.
For reference #5304.

@DanielNoord
Copy link
Collaborator Author

I'm adding to this that https://bugs.python.org/issue33053 seems to have been fixed in 3.7. We mention that issue in here:

https://github.com/PyCQA/pylint/blob/019794b808271d45f86a7014e9c91cb04458a47a/pylint/__init__.py#L56

We need to update the docstring to reflect whatever the situation in 3.7+ is.

I re-read that issue and there is no action to be taken here. We handle this correctly. Ticking off.

@DanielNoord

This comment was marked as outdated.

@DanielNoord
Copy link
Collaborator Author

One final issue here is related to astroid. We need the ComprehensionScope PR to land to fix the coverage drop indicated by the last TODO: 2.14.
I think we can close this as long as we remember to remove those whenever we finally release astroid with that PR in it.

@DanielNoord
Copy link
Collaborator Author

I'm going to move the TODO's that are scheduled for 2.14 to something else as the ComprehensionScope PR has been closed after discussion with @cdce8p.

That means we only need to wait for the beta-period to run out before we can release 2.14. Since many dependency updates seem to take place on Monday ideally I would like to wait at least until May 20th. I'm going to update the OP, but please change the deadline if anybody wants to!

In the meantime I think we can probably focus on getting astroid 2.12 out with pylint-dev/astroid#1542 merged. Seeing as that we managed to release various patch versions while main was on 3.7.2+ while maintenance/2.13.x was not in pylint I think not much is blocking us there.
@jacobtylerwalls do you also want to handle the py-version and related from __future__ import annotations PRs? I can help review those, but feel free to stick to pylint-dev/astroid#1542.

@jacobtylerwalls
Copy link
Member

@jacobtylerwalls do you also want to handle the py-version and related from future import annotations PRs? I can help review those, but feel free to stick to pylint-dev/astroid#1542.

No concrete plans to get to it ATM, but if I can pitch in at some point I will!

@DanielNoord DanielNoord mentioned this issue May 10, 2022
2 tasks
@cdce8p
Copy link
Member

cdce8p commented May 12, 2022

@jacobtylerwalls do you also want to handle the py-version and related from future import annotations PRs? I can help review those, but feel free to stick to PyCQA/astroid#1542.

No concrete plans to get to it ATM, but if I can pitch in at some point I will!

I've started updating the astroid typing following the bump to 3.7.2.
The first PR: pylint-dev/astroid#1555

Edit: Astroid typing update ✅

@jacobtylerwalls
Copy link
Member

In the meantime I think we can probably focus on getting astroid 2.12 out with pylint-dev/astroid#1542 merged.

I'm not sure we need to require a new astroid version so soon. I'd like to look at #4874 for 2.15, and there might be astroid changes. I don't know that we would need to do two astroid releases before pylint==2.15.

@Pierre-Sassoulas
Copy link
Member

I'm trying to have a clean separation in the doc between dev guide and user guide for 2.14 so we can have a clean start regarding the changelog with 2.15 (with #5728). I upgraded the TODO list. We don't have a lot of feedback for the beta at this point, maybe because dependabot suggest upgrading to 3.0.0 alpha if you use 2.14.0.b1 so we might want to release a new 3.0.0 alpha based on, 2.14 to have feedback anyway..

@DanielNoord
Copy link
Collaborator Author

I'd be okay with still releasing this Friday/weekend. I have explicitly made the pylint-config project experimental so there is no harm if we don't work on it for some time and I don't have anything else in the pipeline. So I should have enough time to fix any regressions in a timely manner.
The couple of regressions we found ourselves were all pretty fixable anyway, so that is making me hopeful!

@Pierre-Sassoulas
Copy link
Member

Removed #5728 from the TODO list as including the new changelog file for 2.15 makes more sense after we release 2.14.0. The final MR to check before releasing is #6735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker 🙅 Blocks the next release Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants