Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow batch dimension on data in statespace models #406

Open
jessegrabowski opened this issue Dec 26, 2024 · 0 comments
Open

Allow batch dimension on data in statespace models #406

jessegrabowski opened this issue Dec 26, 2024 · 0 comments
Labels
enhancements New feature or request statespace

Comments

@jessegrabowski
Copy link
Member

jessegrabowski commented Dec 26, 2024

The most requested feature for the statespace module is to handle multiple time series in a single MCMC run. This will require support for batch dimensions. I think the easiest way to attack this will be to refactor the KalmanFilter class to be an OpFromGraph. My original class-based design was inspired by the statsmodels implementation, but it doesn't take full advantage of pytensor.

Thinking more about this, I don't know if KF needs to be an OFG as a first step. It might still be nice to have a AbstractKalmanFilter dummy that we can rewrite to specialized cases, but when I wrote this issue I was a bit obsessed with OFG. The custom gradients are still on my mind, though. So the next two sentences remain true:

An additional advantage of this will be the ability to define a custom gradient. See #332.

Finally, it will let us handle special case filters via rewrites, rather than asking the user to pick a filter up front.

@jessegrabowski jessegrabowski added enhancements New feature or request statespace labels Dec 26, 2024
@jessegrabowski jessegrabowski changed the title Refactor KalmanFilter class as OpFromGraph Allow batch dimension on data in statespace models Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements New feature or request statespace
Projects
None yet
Development

No branches or pull requests

1 participant