You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we should probably not expose all the *Wrapper as the top-level import. Having them under pytest_pyodide.browser sounds more reasonable particularly given that users would use them via fixture and not directly
I think we should probably not expose all the *Wrapper as the top-level import. Having them under pytest_pyodide.browser sounds more reasonable particularly given that users would use them via fixture and not directly
Yes, that sounds reasonable to me.
Wrapper is an odd name that could be improved IMO in this context. And if we do this rename browser.py to runner.py
I'm +1 with it.
not sure why we from fixtures import * but I would be +1 to remove it,
I think we don't need that line anymore, that line was needed before we package pytest-pyodide, but now pytest11 entrypoint will register those fixtures automatically.
Before making a public release of the package it might be good to re-evaluate what is exposed as the public API.
Looking at https://github.com/pyodide/pytest-pyodide/blob/main/pytest_pyodide/__init__.py generally, it looks OK, however,
*Wrapper
as the top-level import. Having them underpytest_pyodide.browser
sounds more reasonable particularly given that users would use them via fixture and not directlybrowser.py
torunner.py
from fixtures import *
but I would be +1 to remove it, and let usersfrom pytest_pyodide.fixtues import ..
explicitlycc @ryanking13
The text was updated successfully, but these errors were encountered: