Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIGHT-TO-LEFT OVERRIDE in AUTHORS.txt #12467

Closed
1 task done
hroncok opened this issue Jan 9, 2024 · 4 comments · Fixed by #12517
Closed
1 task done

RIGHT-TO-LEFT OVERRIDE in AUTHORS.txt #12467

hroncok opened this issue Jan 9, 2024 · 4 comments · Fixed by #12517
Labels
S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior

Comments

@hroncok
Copy link
Contributor

hroncok commented Jan 9, 2024

Description

Hello,

in #12046 I have removed RIGHT-TO-LEFT OVERRIDE from AUTHORS.txt

It was added back in ae23f96

I suspect the file is updated by a script. I am opening this issue to track a modification of that script, so it is not added again.

Expected behavior

No response

pip version

23.2+

Python version

any

OS

any

How to Reproduce

Examine the file on GitHub. It tells you:

This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below.

Output

No response

Code of Conduct

@hroncok hroncok added S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior labels Jan 9, 2024
@pfmoore
Copy link
Member

pfmoore commented Jan 9, 2024

That file is created via the code in https://github.com/pypa/pip/blob/main/tools/release/__init__.py#L48

It looks like it gets the data from git author information, by running git log. I don't have a good idea as to how we can avoid this, TBH.

Does the RIGHT-TO-LEFT OVERRIDE chacater actually cause an issue?

@hroncok
Copy link
Contributor Author

hroncok commented Jan 9, 2024

I can probably add some text processing to that function. Feel free to assign this issue to me.

Does the RIGHT-TO-LEFT OVERRIDE chacater actually cause an issue?

I don't think so. It's being flagged by a CentOS Steram static RPM analysis tool. If you prefer me not to change it, let me know and I'll keep applying a downstream-only change to "satisfy the linter". However, since my original PR was accepted, I assumed changing the automation would be acceptable as well.

@uranusjr
Copy link
Member

A right-to-left override character at the end of the name doesn’t have a practical effect so maybe we could just strip that. I would be fine if a PR is raised to add this auto removal logic to the script.

hroncok added a commit to hroncok/pip that referenced this issue Feb 8, 2024
…om AUTHORS.txt

Since we don't know anything about the names, we assume anything in between
RIGHT-TO-LEFT OVERRIDE and LEFT-TO-RIGHT OVERRIDE (or the end of the name)
should be spelled backwards.

This resulted in a duplicate author name,
because it uses different Unicode form.
So I also added a call to unicodedata.normalize.

Fixes pypa#12467
@hroncok
Copy link
Contributor Author

hroncok commented Feb 8, 2024

See #12517

Took me a while to get to it, sorry about that.

hroncok added a commit to hroncok/pip that referenced this issue Feb 8, 2024
…om AUTHORS.txt

Since we don't know anything about the names, we assume anything in between
RIGHT-TO-LEFT OVERRIDE and LEFT-TO-RIGHT OVERRIDE (or the end of the name)
should be spelled backwards.

This resulted in a duplicate author name,
because it uses different Unicode form.
So I also added a call to unicodedata.normalize.

Fixes pypa#12467
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants