Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weights.plot does not handle named observations #52

Open
ljwolf opened this issue Jun 19, 2018 · 2 comments
Open

weights.plot does not handle named observations #52

ljwolf opened this issue Jun 19, 2018 · 2 comments
Assignees
@ljwolf @slumnitz
Labels
needs testing a pull request which needs testing added, or a bug/rough edge which exposes a functional testing gap no-issue-activity plotting rough edge Something that's not a bug, but that gets in the way of "it just works." weights
Milestone
Next Release

Comments

@ljwolf
Copy link
Member

ljwolf commented Jun 19, 2018

right now, if you have weights constructed using an idVariable or ids list, the plot method fails.

This is because it is using the iloc method to do lookups based on iteration indices.

It should be possible to rework this to use names and only names.
@ljwolf ljwolf added rough edge Something that's not a bug, but that gets in the way of "it just works." and removed scipy2018 labels Jul 21, 2018
@ljwolf ljwolf added the needs testing a pull request which needs testing added, or a bug/rough edge which exposes a functional testing gap label Aug 17, 2018
@ljwolf ljwolf added this to the next milestone Sep 9, 2019
@ljwolf
Copy link
Member Author

ljwolf commented Jan 4, 2020

This is not fixed by #231 (moving to splot weights) which means that the fix must be implemented in splot.plot_spatial_weights.

@github-actions
Copy link

github-actions bot commented Mar 5, 2020

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljwolf ljwolf

@slumnitz slumnitz

Labels
needs testing a pull request which needs testing added, or a bug/rough edge which exposes a functional testing gap no-issue-activity plotting rough edge Something that's not a bug, but that gets in the way of "it just works." weights
Projects
None yet
Milestone
Next Release
Development

No branches or pull requests
4 participants
@sjsrey @ljwolf @jGaboardi @slumnitz