-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include kissat #61
Comments
Hi @haz, Yes, sure, I know what The bottom line is I will add it for sure when there is at least some rudimentary support of incrementality added in Bullet 4 is partially covered by the ability to use AIG graphs now. But having NNFs would be indeed great, absolutely! Thank you! |
Ah, hadn't thought about incremental aspect. Is there any option to have a baseline compatibility for the |
Sorry for this belated response. To be honest, PySAT is all about incrementality and efficient use of original SAT solvers. So I don't see a point right now in including a non-incremental solver here. Let's wait a bit. I am sure Armin will not take too long to add the necessary stuff in kissat. |
@alexeyignatiev this is sad, PySAT seems to be the only generic python frontend for various SAT solvers. Even without incrementality, just solving SAT and being able to switch the solver by changing an argument is very useful. |
If you really just want the hot swap of kissat, then you can use the library we have for nnf: https://python-nnf.readthedocs.io/en/stable/nnf.html#module-nnf.kissat It hooks into pysat as well, but we found it useful to have an out-of-the-box access to kissat (wrapping the command-line rather than the solver internals). It's not entirely ready for prime-time, but |
@hellman, well, I am not completely against adding kissat to PySAT as a non-incremental solver. It's just that I don't feel enough motivation to spend my time doing this if there is only a single possible use-case scenario, which not many I believe will find useful. If you want to add the solver to the toolkit then great, PRs are more than welcome. (But the solver should be used through the API - not an external tool.) |
+1 for inclusion of kissat, especially as the new version won three first places in the 2024 sat competition. |
The latest contest results are out, and we have a new top-solver: http://fmv.jku.at/kissat/
It's an improved version of CaDiCaL, and so hopefully not a big undertaking to include.
In a related note, we'll be shifting the
nnf
package to optionally use thepysat
package for solving. Among other things, this will allow users to write arbitrary NNF formula, compile it using Tseitin, and then solve usingpysat
. The combination of the two libraries should hopefully address what you had in mind with the fourth bullet in the main TODO list.The text was updated successfully, but these errors were encountered: