-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fake_pathlib's resolve() does not reproduce error when path has file ancestor #139
Comments
pathlib
's resolve()
does not reproduce error when path has file ancestor
Thanks for the report - you may be the first user of fake_pathlib so far, so we are certainly happy to get any feedback. I will have a look into this. |
- raise NotADirectoryError where needed so it raised by os.readlink - made pathlib resolve() better conform to real implementation - added strict argument to resolve in Python 3.6 - see #139 - made some fake_pathlib functions available only in 3.5 as in the real implementation
I just added some fixes - please check if this solves your problem. |
@mrbean-bremen Thanks for pointing out this change in 3.6.0b4. It's not very well documented and would have taken me a while to find otherwise. |
Verified that issue is solved on Python 3.6.0b4 with e3449bf. |
Well, we have to check again after the final version gets out - there always may be some changes. Though I don't really expect any, as the final version shall be out in another 2 weeks. |
Yeah. although I wouldn't have expected this kind of compatibility-breaking change between beta releases, either. |
Under Python 3.6:
pyfakefs.fake_pathlib.FakePath.resolve()
does not raise an exception.The text was updated successfully, but these errors were encountered: